From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: arch/powerpc/mm/book3s64/hugetlbpage.c:77 __hash_page_huge() warn: bitwise AND condition is false here
Date: Sun, 12 Apr 2026 12:22:08 +0800 [thread overview]
Message-ID: <202604121243.PfxMMiar-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Alistair Popple <apopple@nvidia.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
CC: Jason Gunthorpe <jgg@nvidia.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f5459048c38a00fc583658d6dcd0f894aff6df8f
commit: bea0cc7cf4a51e8d3a0042212df3b83b49df58a7 powerpc: remove checks for devmap pages and PMDs/PUDs
date: 9 months ago
:::::: branch date: 4 hours ago
:::::: commit date: 9 months ago
config: powerpc64-randconfig-r072-20260412 (https://download.01.org/0day-ci/archive/20260412/202604121243.PfxMMiar-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
smatch: v0.5.0-9004-gb810ac53
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: bea0cc7cf4a5 ("powerpc: remove checks for devmap pages and PMDs/PUDs")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202604121243.PfxMMiar-lkp@intel.com/
smatch warnings:
arch/powerpc/mm/book3s64/hugetlbpage.c:77 __hash_page_huge() warn: bitwise AND condition is false here
vim +77 arch/powerpc/mm/book3s64/hugetlbpage.c
c5710cd2073503 arch/powerpc/mm/book3s64/hash_hugetlbpage.c Christophe Leroy 2019-04-26 18
387e220a2e5e63 arch/powerpc/mm/book3s64/hugetlbpage.c Nicholas Piggin 2021-12-02 19 #ifdef CONFIG_PPC_64S_HASH_MMU
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 20 int __hash_page_huge(unsigned long ea, unsigned long access, unsigned long vsid,
aefa5688c07072 arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2014-12-04 21 pte_t *ptep, unsigned long trap, unsigned long flags,
aefa5688c07072 arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2014-12-04 22 int ssize, unsigned int shift, unsigned int mmu_psize)
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 23 {
bf9a95f9a6481b arch/powerpc/mm/hugetlbpage-hash64.c Ram Pai 2017-11-06 24 real_pte_t rpte;
5524a27d39b687 arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2012-09-10 25 unsigned long vpn;
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 26 unsigned long old_pte, new_pte;
8132cf115efc3b arch/powerpc/mm/hugetlbpage-hash64.c Qian Cai 2019-02-27 27 unsigned long rflags, pa;
ff31e105464d8c arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2018-02-11 28 long slot, offset;
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 29
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 30 BUG_ON(shift != mmu_psize_defs[mmu_psize].shift);
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 31
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 32 /* Search the Linux page table for a match with va */
5524a27d39b687 arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2012-09-10 33 vpn = hpt_vpn(ea, vsid, ssize);
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 34
47d99948eee48a arch/powerpc/mm/book3s64/hash_hugetlbpage.c Christophe Leroy 2019-03-29 35 /*
47d99948eee48a arch/powerpc/mm/book3s64/hash_hugetlbpage.c Christophe Leroy 2019-03-29 36 * At this point, we have a pte (old_pte) which can be used to build
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 37 * or update an HPTE. There are 2 cases:
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 38 *
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 39 * 1. There is a valid (present) pte with no associated HPTE (this is
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 40 * the most common case)
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 41 * 2. There is a valid (present) pte with an associated HPTE. The
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 42 * current values of the pp bits in the HPTE prevent access
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 43 * because we are doing software DIRTY bit management and the
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 44 * page is currently not DIRTY.
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 45 */
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 46
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 47
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 48 do {
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 49 old_pte = pte_val(*ptep);
171aa2caaad16e arch/powerpc/mm/hugetlbpage-hash64.c Benjamin Herrenschmidt 2010-07-23 50 /* If PTE busy, retry the access */
945537df7a107e arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2016-04-29 51 if (unlikely(old_pte & H_PAGE_BUSY))
171aa2caaad16e arch/powerpc/mm/hugetlbpage-hash64.c Benjamin Herrenschmidt 2010-07-23 52 return 0;
171aa2caaad16e arch/powerpc/mm/hugetlbpage-hash64.c Benjamin Herrenschmidt 2010-07-23 53 /* If PTE permissions don't match, take page fault */
ac29c64089b74d arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2016-04-29 54 if (unlikely(!check_pte_access(access, old_pte)))
171aa2caaad16e arch/powerpc/mm/hugetlbpage-hash64.c Benjamin Herrenschmidt 2010-07-23 55 return 1;
57fb15c32f4f6a arch/powerpc/mm/book3s64/hugetlbpage.c Christophe Leroy 2024-07-02 56 /*
57fb15c32f4f6a arch/powerpc/mm/book3s64/hugetlbpage.c Christophe Leroy 2024-07-02 57 * If hash-4k, hugepages use seeral contiguous PxD entries
57fb15c32f4f6a arch/powerpc/mm/book3s64/hugetlbpage.c Christophe Leroy 2024-07-02 58 * so bail out and let mm make the page young or dirty
57fb15c32f4f6a arch/powerpc/mm/book3s64/hugetlbpage.c Christophe Leroy 2024-07-02 59 */
57fb15c32f4f6a arch/powerpc/mm/book3s64/hugetlbpage.c Christophe Leroy 2024-07-02 60 if (IS_ENABLED(CONFIG_PPC_4K_PAGES)) {
57fb15c32f4f6a arch/powerpc/mm/book3s64/hugetlbpage.c Christophe Leroy 2024-07-02 61 if (!(old_pte & _PAGE_ACCESSED))
57fb15c32f4f6a arch/powerpc/mm/book3s64/hugetlbpage.c Christophe Leroy 2024-07-02 62 return 1;
57fb15c32f4f6a arch/powerpc/mm/book3s64/hugetlbpage.c Christophe Leroy 2024-07-02 63 if ((access & _PAGE_WRITE) && !(old_pte & _PAGE_DIRTY))
57fb15c32f4f6a arch/powerpc/mm/book3s64/hugetlbpage.c Christophe Leroy 2024-07-02 64 return 1;
57fb15c32f4f6a arch/powerpc/mm/book3s64/hugetlbpage.c Christophe Leroy 2024-07-02 65 }
ac29c64089b74d arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2016-04-29 66
47d99948eee48a arch/powerpc/mm/book3s64/hash_hugetlbpage.c Christophe Leroy 2019-03-29 67 /*
47d99948eee48a arch/powerpc/mm/book3s64/hash_hugetlbpage.c Christophe Leroy 2019-03-29 68 * Try to lock the PTE, add ACCESSED and DIRTY if it was
47d99948eee48a arch/powerpc/mm/book3s64/hash_hugetlbpage.c Christophe Leroy 2019-03-29 69 * a write access
47d99948eee48a arch/powerpc/mm/book3s64/hash_hugetlbpage.c Christophe Leroy 2019-03-29 70 */
945537df7a107e arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2016-04-29 71 new_pte = old_pte | H_PAGE_BUSY | _PAGE_ACCESSED;
c7d54842deb1fa arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2016-04-29 72 if (access & _PAGE_WRITE)
171aa2caaad16e arch/powerpc/mm/hugetlbpage-hash64.c Benjamin Herrenschmidt 2010-07-23 73 new_pte |= _PAGE_DIRTY;
3910a7f485e122 arch/powerpc/mm/hugetlbpage-hash64.c Michael Ellerman 2016-04-29 74 } while(!pte_xchg(ptep, __pte(old_pte), __pte(new_pte)));
3910a7f485e122 arch/powerpc/mm/hugetlbpage-hash64.c Michael Ellerman 2016-04-29 75
75646c480fdeff arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2018-09-20 76 /* Make sure this is a hugetlb entry */
bea0cc7cf4a51e arch/powerpc/mm/book3s64/hugetlbpage.c Alistair Popple 2025-06-19 @77 if (old_pte & H_PAGE_THP_HUGE)
75646c480fdeff arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2018-09-20 78 return 0;
75646c480fdeff arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2018-09-20 79
d94b827e89dc3f arch/powerpc/mm/book3s64/hash_hugetlbpage.c Aneesh Kumar K.V 2020-11-27 80 rflags = htab_convert_pte_flags(new_pte, flags);
ff31e105464d8c arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2018-02-11 81 if (unlikely(mmu_psize == MMU_PAGE_16G))
ff31e105464d8c arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2018-02-11 82 offset = PTRS_PER_PUD;
ff31e105464d8c arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2018-02-11 83 else
ff31e105464d8c arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2018-02-11 84 offset = PTRS_PER_PMD;
ff31e105464d8c arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2018-02-11 85 rpte = __real_pte(__pte(old_pte), ptep, offset);
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 86
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 87 if (!cpu_has_feature(CPU_FTR_COHERENT_ICACHE))
47d99948eee48a arch/powerpc/mm/book3s64/hash_hugetlbpage.c Christophe Leroy 2019-03-29 88 /*
47d99948eee48a arch/powerpc/mm/book3s64/hash_hugetlbpage.c Christophe Leroy 2019-03-29 89 * No CPU has hugepages but lacks no execute, so we
47d99948eee48a arch/powerpc/mm/book3s64/hash_hugetlbpage.c Christophe Leroy 2019-03-29 90 * don't need to worry about that case
47d99948eee48a arch/powerpc/mm/book3s64/hash_hugetlbpage.c Christophe Leroy 2019-03-29 91 */
0895ecda79428d arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 92 rflags = hash_page_do_lazy_icache(rflags, __pte(old_pte), trap);
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 93
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 94 /* Check if pte already has an hpte (case 2) */
945537df7a107e arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2016-04-29 95 if (unlikely(old_pte & H_PAGE_HASHPTE)) {
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 96 /* There MIGHT be an HPTE for this pte */
bf9a95f9a6481b arch/powerpc/mm/hugetlbpage-hash64.c Ram Pai 2017-11-06 97 unsigned long gslot;
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 98
bf9a95f9a6481b arch/powerpc/mm/hugetlbpage-hash64.c Ram Pai 2017-11-06 99 gslot = pte_get_hash_gslot(vpn, shift, ssize, rpte, 0);
bf9a95f9a6481b arch/powerpc/mm/hugetlbpage-hash64.c Ram Pai 2017-11-06 100 if (mmu_hash_ops.hpte_updatepp(gslot, rflags, vpn, mmu_psize,
aefa5688c07072 arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2014-12-04 101 mmu_psize, ssize, flags) == -1)
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 102 old_pte &= ~_PAGE_HPTEFLAGS;
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 103 }
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 104
945537df7a107e arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2016-04-29 105 if (likely(!(old_pte & H_PAGE_HASHPTE))) {
5524a27d39b687 arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2012-09-10 106 unsigned long hash = hpt_hash(vpn, shift, ssize);
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 107
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 108 pa = pte_pfn(__pte(old_pte)) << PAGE_SHIFT;
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 109
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 110 /* clear HPTE slot informations in new PTE */
945537df7a107e arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2016-04-29 111 new_pte = (new_pte & ~_PAGE_HPTEFLAGS) | H_PAGE_HASHPTE;
bf680d51605662 arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2015-12-01 112
b170bd3de6a7f6 arch/powerpc/mm/hugetlbpage-hash64.c Li Zhong 2013-04-15 113 slot = hpte_insert_repeating(hash, vpn, pa, rflags, 0,
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 114 mmu_psize, ssize);
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 115
b1623e7eb280f8 arch/powerpc/mm/hugetlbpage-hash64.c Anton Blanchard 2010-07-14 116 /*
b1623e7eb280f8 arch/powerpc/mm/hugetlbpage-hash64.c Anton Blanchard 2010-07-14 117 * Hypervisor failure. Restore old pte and return -1
b1623e7eb280f8 arch/powerpc/mm/hugetlbpage-hash64.c Anton Blanchard 2010-07-14 118 * similar to __hash_page_*
b1623e7eb280f8 arch/powerpc/mm/hugetlbpage-hash64.c Anton Blanchard 2010-07-14 119 */
b1623e7eb280f8 arch/powerpc/mm/hugetlbpage-hash64.c Anton Blanchard 2010-07-14 120 if (unlikely(slot == -2)) {
b1623e7eb280f8 arch/powerpc/mm/hugetlbpage-hash64.c Anton Blanchard 2010-07-14 121 *ptep = __pte(old_pte);
4b8692c022a4b1 arch/powerpc/mm/hugetlbpage-hash64.c Benjamin Herrenschmidt 2010-07-23 122 hash_failure_debug(ea, access, vsid, trap, ssize,
d8139ebf8596a1 arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2013-04-28 123 mmu_psize, mmu_psize, old_pte);
171aa2caaad16e arch/powerpc/mm/hugetlbpage-hash64.c Benjamin Herrenschmidt 2010-07-23 124 return -1;
b1623e7eb280f8 arch/powerpc/mm/hugetlbpage-hash64.c Anton Blanchard 2010-07-14 125 }
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 126
ff31e105464d8c arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2018-02-11 127 new_pte |= pte_set_hidx(ptep, rpte, 0, slot, offset);
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 128 }
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 129
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 130 /*
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 131 * No need to use ldarx/stdcx here
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 132 */
945537df7a107e arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2016-04-29 133 *ptep = __pte(new_pte & ~H_PAGE_BUSY);
171aa2caaad16e arch/powerpc/mm/hugetlbpage-hash64.c Benjamin Herrenschmidt 2010-07-23 134 return 0;
883a3e523672eb arch/powerpc/mm/hugetlbpage-hash64.c David Gibson 2009-10-26 135 }
387e220a2e5e63 arch/powerpc/mm/book3s64/hugetlbpage.c Nicholas Piggin 2021-12-02 136 #endif
8ef5cbde6dafce arch/powerpc/mm/hugetlbpage-hash64.c Aneesh Kumar K.V 2019-03-05 137
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-04-12 4:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-12 4:22 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-12-23 15:36 arch/powerpc/mm/book3s64/hugetlbpage.c:77 __hash_page_huge() warn: bitwise AND condition is false here kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202604121243.PfxMMiar-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.