From: Jakub Kicinski <kuba@kernel.org>
To: Ashutosh Desai <ashutoshdesai993@gmail.com>
Cc: netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
davem@davemloft.net, pabeni@redhat.com, horms@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nfc: hci: fix OOB heap read on short HCP frames
Date: Sun, 12 Apr 2026 13:42:18 -0700 [thread overview]
Message-ID: <20260412134218.34cbe88d@kernel.org> (raw)
In-Reply-To: <20260409150825.2217133-1-ashutoshdesai993@gmail.com>
On Thu, 9 Apr 2026 15:08:25 +0000 Ashutosh Desai wrote:
> Suggested-by: Eric Dumazet <edumazet@google.com>
As Eric mentioned elsewhere - he did not suggest any of this,
merely reviewed your submission.
> +++ b/net/nfc/hci/core.c
> @@ -134,6 +134,10 @@ static void nfc_hci_msg_rx_work(struct work_struct *work)
> u8 instruction;
>
> while ((skb = skb_dequeue(&hdev->msg_rx_queue)) != NULL) {
> + if (!pskb_may_pull(skb, NFC_HCI_HCP_HEADER_LEN)) {
> + kfree_skb(skb);
> + continue;
How did a broken packet get enqueued in the first place?
next prev parent reply other threads:[~2026-04-12 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAKapqNnOF6BO2zE0MwNeM2_Hchp_d-qDQffywCg7Bk-pMcFKpw@mail.gmail.com>
2026-04-09 7:14 ` [PATCH] nfc: hci: fix OOB heap read on short HCP frames Eric Dumazet
2026-04-09 15:08 ` [PATCH v2] " Ashutosh Desai
2026-04-12 20:42 ` Jakub Kicinski [this message]
2026-04-13 0:06 ` Ashutosh Desai
2026-04-13 2:43 ` [PATCH v3] nfc: hci: fix out-of-bounds read in HCP header parsing Ashutosh Desai
2026-04-13 17:55 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260412134218.34cbe88d@kernel.org \
--to=kuba@kernel.org \
--cc=ashutoshdesai993@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.