[android-common:mirror-poly-aosp-pixel-malibu-staging 1/1] drivers/usb/musb/da8xx.c:86: warning: Function parameter or struct member 'musb' not described in 'da8xx_musb_enable'

[kernel test robot <lkp@intel.com>]

Hi David,

First bad commit (maybe != root cause):

tree:   https://android.googlesource.com/kernel/common mirror-poly-aosp-pixel-malibu-staging
head:   5f9b673221e971553e198f78304aa6f4db751402
commit: dfc80ed249b618f2cf48481adc8aff0d8ef444b4 [1/1] ARM: davinci: da850: fix selecting ARCH_DAVINCI_DA8XX
config: arm-randconfig-r073-20260412 (https://download.01.org/0day-ci/archive/20260412/202604121600.kD4AXihx-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 8.5.0
smatch: v0.5.0-9004-gb810ac53
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260412/202604121600.kD4AXihx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604121600.kD4AXihx-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/usb/musb/da8xx.c:86: warning: Function parameter or struct member 'musb' not described in 'da8xx_musb_enable'
>> drivers/usb/musb/da8xx.c:105: warning: Function parameter or struct member 'musb' not described in 'da8xx_musb_disable'


vim +86 drivers/usb/musb/da8xx.c

e6480faa1067af9 Felipe Balbi    2010-12-02   74  
3ee076dea68e11d Sergei Shtylyov 2010-09-24   75  /*
3ee076dea68e11d Sergei Shtylyov 2010-09-24   76   * Because we don't set CTRL.UINT, it's "important" to:
3ee076dea68e11d Sergei Shtylyov 2010-09-24   77   *	- not read/write INTRUSB/INTRUSBE (except during
3ee076dea68e11d Sergei Shtylyov 2010-09-24   78   *	  initial setup, as a workaround);
3ee076dea68e11d Sergei Shtylyov 2010-09-24   79   *	- use INTSET/INTCLR instead.
3ee076dea68e11d Sergei Shtylyov 2010-09-24   80   */
3ee076dea68e11d Sergei Shtylyov 2010-09-24   81  
3ee076dea68e11d Sergei Shtylyov 2010-09-24   82  /**
743411b3f3e96e8 Felipe Balbi    2010-12-01   83   * da8xx_musb_enable - enable interrupts
3ee076dea68e11d Sergei Shtylyov 2010-09-24   84   */
743411b3f3e96e8 Felipe Balbi    2010-12-01   85  static void da8xx_musb_enable(struct musb *musb)
3ee076dea68e11d Sergei Shtylyov 2010-09-24  @86  {
3ee076dea68e11d Sergei Shtylyov 2010-09-24   87  	void __iomem *reg_base = musb->ctrl_base;
3ee076dea68e11d Sergei Shtylyov 2010-09-24   88  	u32 mask;
3ee076dea68e11d Sergei Shtylyov 2010-09-24   89  
3ee076dea68e11d Sergei Shtylyov 2010-09-24   90  	/* Workaround: setup IRQs through both register sets. */
3ee076dea68e11d Sergei Shtylyov 2010-09-24   91  	mask = ((musb->epmask & DA8XX_USB_TX_EP_MASK) << DA8XX_INTR_TX_SHIFT) |
3ee076dea68e11d Sergei Shtylyov 2010-09-24   92  	       ((musb->epmask & DA8XX_USB_RX_EP_MASK) << DA8XX_INTR_RX_SHIFT) |
3ee076dea68e11d Sergei Shtylyov 2010-09-24   93  	       DA8XX_INTR_USB_MASK;
3ee076dea68e11d Sergei Shtylyov 2010-09-24   94  	musb_writel(reg_base, DA8XX_USB_INTR_MASK_SET_REG, mask);
3ee076dea68e11d Sergei Shtylyov 2010-09-24   95  
3ee076dea68e11d Sergei Shtylyov 2010-09-24   96  	/* Force the DRVVBUS IRQ so we can start polling for ID change. */
3ee076dea68e11d Sergei Shtylyov 2010-09-24   97  	musb_writel(reg_base, DA8XX_USB_INTR_SRC_SET_REG,
3ee076dea68e11d Sergei Shtylyov 2010-09-24   98  			DA8XX_INTR_DRVVBUS << DA8XX_INTR_USB_SHIFT);
3ee076dea68e11d Sergei Shtylyov 2010-09-24   99  }
3ee076dea68e11d Sergei Shtylyov 2010-09-24  100  
3ee076dea68e11d Sergei Shtylyov 2010-09-24  101  /**
743411b3f3e96e8 Felipe Balbi    2010-12-01  102   * da8xx_musb_disable - disable HDRC and flush interrupts
3ee076dea68e11d Sergei Shtylyov 2010-09-24  103   */
743411b3f3e96e8 Felipe Balbi    2010-12-01  104  static void da8xx_musb_disable(struct musb *musb)
3ee076dea68e11d Sergei Shtylyov 2010-09-24 @105  {
3ee076dea68e11d Sergei Shtylyov 2010-09-24  106  	void __iomem *reg_base = musb->ctrl_base;
3ee076dea68e11d Sergei Shtylyov 2010-09-24  107  
3ee076dea68e11d Sergei Shtylyov 2010-09-24  108  	musb_writel(reg_base, DA8XX_USB_INTR_MASK_CLEAR_REG,
3ee076dea68e11d Sergei Shtylyov 2010-09-24  109  		    DA8XX_INTR_USB_MASK |
3ee076dea68e11d Sergei Shtylyov 2010-09-24  110  		    DA8XX_INTR_TX_MASK | DA8XX_INTR_RX_MASK);
3ee076dea68e11d Sergei Shtylyov 2010-09-24  111  	musb_writel(reg_base, DA8XX_USB_END_OF_INTR_REG, 0);
3ee076dea68e11d Sergei Shtylyov 2010-09-24  112  }
3ee076dea68e11d Sergei Shtylyov 2010-09-24  113  

:::::: The code at line 86 was first introduced by commit
:::::: 3ee076dea68e11d4685972df7298b80b8e7673e4 usb: musb: introduce DA8xx/OMAP-L1x glue layer

:::::: TO: Sergei Shtylyov <sshtylyov@ru.mvista.com>
:::::: CC: Greg Kroah-Hartman <gregkh@suse.de>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki