From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39605F34C69 for ; Mon, 13 Apr 2026 16:55:03 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCKWy-0006nH-9C; Mon, 13 Apr 2026 12:53:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCKWw-0006mw-Mn for qemu-devel@nongnu.org; Mon, 13 Apr 2026 12:52:58 -0400 Received: from p-west2-cluster3-host9-snip4-10.eps.apple.com ([57.103.69.73] helo=outbound.mr.icloud.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCKWv-0005Cl-7D for qemu-devel@nongnu.org; Mon, 13 Apr 2026 12:52:58 -0400 Received: from outbound.mr.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-west-2a-10-percent-1 (Postfix) with ESMTPS id 0ED5C1803B94; Mon, 13 Apr 2026 16:52:54 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr; s=sig1; t=1776099176; x=1778691176; bh=jSFEY3OW57r5Gmf0SB6G349rIgUNCT10rXc1M/CBSww=; h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme; b=PvccHx7PvzHmF3vMEdsLETkZnnUwuGMzSf8xqKW1ZW8c0L11s5cT7zv33vKmzX41qLTuzF/dZrDS4V2pmckEDVCprVhRKLOY73eh0XuQ8ZnR/VouEVs7txtpa2PUHcJ65oJRBd9c06YNXZwTyUhXos8lOOXWUA93Tad/nuouiz8+MHMN573b7xJhyMIziqlNHKYTdqnVg3QS9dfW386vCjIt0iDjZYAE4Z3qPRaUnAe6SnSRNIq7aBrv0sYfpzx1E+2eiuiimE88ffe1gbFemqOFCff/FLJJ6DUsc4swAN9z1Aa12lRDCTtHUHZuzljyCgjZrt2sOALocw9m30NQbw== mail-alias-created-date: 1752046281608 Received: from localhost.localdomain (unknown [17.57.152.38]) by p00-icloudmta-asmtp-us-west-2a-10-percent-1 (Postfix) with ESMTPSA id BE50A1803BAD; Mon, 13 Apr 2026 16:52:28 +0000 (UTC) From: Mohamed Mediouni To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Pedro Barbuda , Mohamed Mediouni , Paolo Bonzini , Zhao Liu , Roman Bolshakov , Wei Liu , Phil Dennis-Jordan Subject: [PATCH v11 01/15] target/i386: emulate: include name of unhandled instruction Date: Mon, 13 Apr 2026 18:52:03 +0200 Message-ID: <20260413165217.47105-2-mohamed@unpredictable.fr> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260413165217.47105-1-mohamed@unpredictable.fr> References: <20260413165217.47105-1-mohamed@unpredictable.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: SFoHx0F6OAK2uSAMZBhwRZxjpRQL8sab X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEzMDE2NiBTYWx0ZWRfX6xqYqYLaFLeo B6RdLnn+RUCJtG/97gm/thuX8hJObWsNKRzKz3+/0Yr2Y6jhK9gEncoMoxN6mvHdKptWg3H2JGb ncqK5U5gSqNP5SvN+qtkVt3tUNwRSSVH+/VfNJrvBqh/KYPFS7Rm4vfHmxJ2TGA56hgm7YjcbLh +oCVgpgD3sbm7ougjXh0lhnI/QsGVpSP9XQYfTX/cRBXWYa5mJgMDeeZpYyQsnYpyCl1JcRZ4Lg B9npnhA7rtxoiEE1mbgWOdB3FRmr1r1j/UvRHyhQdRL5n2QxhPSsqY5UNQ6MoVYS7v6cJitL0b7 C7lJCicRVEZYsJwxLbi+oj/TX1S8F8BaJGKow2iRbPKE0JT1YSoEDFgMTzz4xg= X-Proofpoint-GUID: SFoHx0F6OAK2uSAMZBhwRZxjpRQL8sab X-Authority-Info-Out: v=2.4 cv=DohbOW/+ c=1 sm=1 tr=0 ts=69dd1f67 cx=c_apl:c_pps:t_out a=9OgfyREA4BUYbbCgc0Y0oA==:117 a=9OgfyREA4BUYbbCgc0Y0oA==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=x0iqa3ucmZZh0HPruXgA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-13_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 clxscore=1030 mlxlogscore=900 adultscore=0 mlxscore=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2604130166 Received-SPF: pass client-ip=57.103.69.73; envelope-from=mohamed@unpredictable.fr; helo=outbound.mr.icloud.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Instead of just the command number, include the instruction name to make debugging easier. Signed-off-by: Mohamed Mediouni --- target/i386/emulate/x86_emu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/emulate/x86_emu.c b/target/i386/emulate/x86_emu.c index 55b1a68eb6..c2da1a133f 100644 --- a/target/i386/emulate/x86_emu.c +++ b/target/i386/emulate/x86_emu.c @@ -1399,8 +1399,8 @@ static void init_cmd_handler(void) bool exec_instruction(CPUX86State *env, struct x86_decode *ins) { if (!_cmd_handler[ins->cmd].handler) { - printf("Unimplemented handler (" TARGET_FMT_lx ") for %d (%x %x)\n", - env->eip, + printf("Unimplemented handler (" TARGET_FMT_lx ") for %s - %d (%x %x)\n", + env->eip, decode_cmd_to_string(ins->cmd), ins->cmd, ins->opcode[0], ins->opcode_len > 1 ? ins->opcode[1] : 0); env->eip += ins->len; -- 2.50.1 (Apple Git-155)