Re: [PATCH v3 2/4] perf: Use a union to clear branch entry bitfields

[sashiko-bot@kernel.org]

Sashiko AI review found 1 potential issue(s):
- [Low] Missing tools/ UAPI header synchronization causing build warnings.
--

Note: The format of this review is altered and does not contain inline patch
quotes due to automated recitation restrictions.

commit 0f3b756dec935106f8ca717cac2777f750f3b8da
Author: Puranjay Mohan <puranjay@kernel.org>
perf: Use a union to clear branch entry bitfields

This commit wraps the bitfields of struct perf_branch_entry in an anonymous
struct inside a union, allowing them to be cleared via a single assignment.

The patch updates include/uapi/linux/perf_event.h to introduce the new
union and struct layout for perf_branch_entry, but it does not appear to
apply the corresponding change to tools/include/uapi/linux/perf_event.h.

Will this discrepancy trigger a build warning in the perf tools? The kernel's
tools/perf/check-headers.sh script explicitly tracks this UAPI header. When
these files drift, it usually results in a warning during the tools build
stating that the Kernel ABI header differs from the latest version.

Should the tools/include/uapi/linux/perf_event.h header be synchronized in
this patch to avoid breaking the header checks?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260413185740.3286146-1-puranjay@kernel.org?part=2