From: Jamin Lin <jamin_lin@aspeedtech.com>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Kane Chen" <kane_chen@aspeedtech.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: "Jamin Lin" <jamin_lin@aspeedtech.com>,
"Troy Lee" <troy_lee@aspeedtech.com>,
"flwu@google.com" <flwu@google.com>,
"nabihestefan@google.com" <nabihestefan@google.com>,
"Cédric Le Goater" <clg@redhat.com>
Subject: [PATCH v2 02/17] hw/usb/hcd-ehci.h: Fix coding style issues reported by checkpatch
Date: Tue, 14 Apr 2026 08:00:28 +0000 [thread overview]
Message-ID: <20260414080025.3005916-3-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com>
No functional change.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
---
hw/usb/hcd-ehci.h | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h
index 3aec0e047c..736407fd52 100644
--- a/hw/usb/hcd-ehci.h
+++ b/hw/usb/hcd-ehci.h
@@ -43,7 +43,8 @@ typedef struct EHCIPacket EHCIPacket;
typedef struct EHCIQueue EHCIQueue;
typedef struct EHCIState EHCIState;
-/* EHCI spec version 1.0 Section 3.3
+/*
+ * EHCI spec version 1.0 Section 3.3
*/
typedef struct EHCIitd {
uint32_t next;
@@ -74,7 +75,8 @@ typedef struct EHCIitd {
#define ITD_BUFPTR_MULT_SH 0
} EHCIitd;
-/* EHCI spec version 1.0 Section 3.4
+/*
+ * EHCI spec version 1.0 Section 3.4
*/
typedef struct EHCIsitd {
uint32_t next; /* Standard next link pointer */
@@ -118,7 +120,8 @@ typedef struct EHCIsitd {
uint32_t backptr; /* Standard next link pointer */
} EHCIsitd;
-/* EHCI spec version 1.0 Section 3.5
+/*
+ * EHCI spec version 1.0 Section 3.5
*/
typedef struct EHCIqtd {
uint32_t next; /* Standard next link pointer */
@@ -148,7 +151,8 @@ typedef struct EHCIqtd {
#define QTD_BUFPTR_SH 12
} EHCIqtd;
-/* EHCI spec version 1.0 Section 3.6
+/*
+ * EHCI spec version 1.0 Section 3.6
*/
typedef struct EHCIqh {
uint32_t next; /* Standard next link pointer */
@@ -230,7 +234,8 @@ struct EHCIQueue {
int async;
int transact_ctr;
- /* cached data from guest - needs to be flushed
+ /*
+ * cached data from guest - needs to be flushed
* when guest removes an entry (doorbell, handshake sequence)
*/
EHCIqh qh; /* copy of current QH (being worked on) */
@@ -268,7 +273,7 @@ struct EHCIState {
*/
uint8_t caps[CAPA_SIZE];
union {
- uint32_t opreg[0x44/sizeof(uint32_t)];
+ uint32_t opreg[0x44 / sizeof(uint32_t)];
struct {
uint32_t usbcmd;
uint32_t usbsts;
--
2.43.0
next prev parent reply other threads:[~2026-04-14 8:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 8:00 [PATCH v2 00/17] hw/usb/ehci: Add 64-bit descriptor addressing support Jamin Lin
2026-04-14 8:00 ` [PATCH v2 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn structure and dead code Jamin Lin
2026-04-14 8:00 ` Jamin Lin [this message]
2026-04-14 8:00 ` [PATCH v2 03/17] hw/usb/hcd-ehci.c: Fix coding style issues reported by checkpatch Jamin Lin
2026-04-14 8:00 ` [PATCH v2 04/17] hw/usb/hcd-ehci.c: Replace fprintf(stderr, ...) with qemu_log_mask(LOG_GUEST_ERROR) Jamin Lin
2026-04-14 8:00 ` [PATCH v2 05/17] hw/usb/hcd-ehci: Replace DPRINTF debug logs with trace events Jamin Lin
2026-04-14 8:00 ` [PATCH v2 06/17] hw/usb/hcd-ehci: Change descriptor addresses to 64-bit Jamin Lin
2026-04-14 9:22 ` Philippe Mathieu-Daudé
2026-04-15 0:54 ` Jamin Lin
2026-04-15 9:03 ` Philippe Mathieu-Daudé
2026-04-14 8:00 ` [PATCH v2 07/17] hw/usb/hcd-ehci: Add property to advertise 64-bit addressing capability Jamin Lin
2026-04-14 8:00 ` [PATCH v2 08/17] hw/usb/hcd-ehci: Reject CTRLDSSEGMENT writes without 64-bit capability Jamin Lin
2026-04-14 8:00 ` [PATCH v2 09/17] hw/usb/hcd-ehci: Implement 64-bit QH descriptor addressing Jamin Lin
2026-04-14 8:00 ` [PATCH v2 10/17] hw/usb/hcd-ehci: Implement 64-bit qTD " Jamin Lin
2026-04-14 8:00 ` [PATCH v2 11/17] hw/usb/hcd-ehci: Implement 64-bit iTD " Jamin Lin
2026-04-14 8:00 ` [PATCH v2 12/17] hw/usb/hcd-ehci: Implement 64-bit siTD " Jamin Lin
2026-04-14 8:00 ` [PATCH v2 13/17] hw/usb/hcd-ehci: Add descriptor address offset property Jamin Lin
2026-04-14 8:00 ` [PATCH v2 14/17] hw/arm/aspeed_ast27x0: Enable 64-bit EHCI DMA addressing Jamin Lin
2026-04-14 8:00 ` [PATCH v2 15/17] hw/arm/aspeed_ast27x0: Set EHCI descriptor address offset Jamin Lin
2026-04-14 8:00 ` [PATCH v2 16/17] tests/functional/arm/test_aspeed_ast2600_sdk: Add USB EHCI test for AST2600 SDK Jamin Lin
2026-04-14 8:00 ` [PATCH v2 17/17] tests/functional/aarch64/test_aspeed_ast2700: Add USB EHCI test for AST2700 A1/A2 Jamin Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260414080025.3005916-3-jamin_lin@aspeedtech.com \
--to=jamin_lin@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=clg@redhat.com \
--cc=flwu@google.com \
--cc=joel@jms.id.au \
--cc=kane_chen@aspeedtech.com \
--cc=leetroy@gmail.com \
--cc=nabihestefan@google.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.