All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v3] Bluetooth: btintel_pcie: Support Product level reset
Date: Tue, 14 Apr 2026 08:26:02 +0800	[thread overview]
Message-ID: <202604140816.wm7rA2AH-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20260413042041.1318723-1-chandrashekar.devegowda@intel.com>
References: <20260413042041.1318723-1-chandrashekar.devegowda@intel.com>
TO: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
TO: linux-bluetooth@vger.kernel.org
CC: linux-pci@vger.kernel.org
CC: bhelgaas@google.com
CC: ravishankar.srivatsa@intel.com
CC: chethan.tumkur.narayan@intel.com
CC: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>

Hi Chandrashekar,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bluetooth-next/master]
[cannot apply to bluetooth/master linus/master v7.0]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chandrashekar-Devegowda/Bluetooth-btintel_pcie-Support-Product-level-reset/20260414-025925
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
patch link:    https://lore.kernel.org/r/20260413042041.1318723-1-chandrashekar.devegowda%40intel.com
patch subject: [PATCH v3] Bluetooth: btintel_pcie: Support Product level reset
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
config: i386-randconfig-141-20260414 (https://download.01.org/0day-ci/archive/20260414/202604140816.wm7rA2AH-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
smatch: v0.5.0-9007-gcf3ea02b

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202604140816.wm7rA2AH-lkp@intel.com/

smatch warnings:
drivers/bluetooth/btintel_pcie.c:2405 btintel_pcie_reset_work() warn: can 'data' even be NULL?

vim +/data +2405 drivers/bluetooth/btintel_pcie.c

d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2392  
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2393  static void btintel_pcie_reset_work(struct work_struct *wk)
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2394  {
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2395  	struct btintel_pcie_data *data =
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2396  		container_of(wk, struct btintel_pcie_data, reset_work);
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2397  	struct pci_dev *pdev = data->pdev;
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2398  	int err;
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2399  
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2400  	pci_lock_rescan_remove();
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2401  
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2402  	if (!pdev->bus)
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2403  		goto out;
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2404  
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13 @2405  	if (!data)
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2406  		goto out;
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2407  
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2408  	btintel_pcie_disable_interrupts(data);
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2409  	btintel_pcie_synchronize_irqs(data);
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2410  
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2411  	flush_work(&data->rx_work);
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2412  
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2413  	bt_dev_dbg(data->hdev, "Release bluetooth interface");
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2414  	if (data->reset_type == BTINTEL_PCIE_IOSF_PRR_PLDR) {
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2415  		/* This function holds pci_lock_rescan_remove(), which acquires
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2416  		 * pci_rescan_remove_lock. This mutex serializes against PCI device
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2417  		 * addition/removal (hotplug), so no device can be added to or
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2418  		 * removed from the bus list while this code runs.
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2419  		 */
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2420  		btintel_pcie_perform_pldr(data);
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2421  		goto out;
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2422  	}
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2423  	btintel_pcie_release_hdev(data);
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2424  
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2425  	err = pci_reset_function(pdev);
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2426  	if (err) {
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2427  		BT_ERR("Failed resetting the pcie device (%d)", err);
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2428  		goto out;
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2429  	}
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2430  
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2431  	btintel_pcie_enable_interrupts(data);
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2432  	btintel_pcie_config_msix(data);
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2433  
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2434  	err = btintel_pcie_enable_bt(data);
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2435  	if (err) {
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2436  		BT_ERR("Failed to enable bluetooth hardware after reset (%d)",
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2437  		       err);
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2438  		goto out;
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2439  	}
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2440  
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2441  	btintel_pcie_reset_ia(data);
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2442  	btintel_pcie_start_rx(data);
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2443  	data->flags = 0;
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2444  
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2445  	err = btintel_pcie_setup_hdev(data);
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2446  	if (err) {
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2447  		BT_ERR("Failed registering hdev (%d)", err);
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2448  		goto out;
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2449  	}
d12004a0c6a569 Chandrashekar Devegowda 2026-04-13  2450  out:
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2451  	pci_dev_put(pdev);
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2452  	pci_unlock_rescan_remove();
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2453  }
256ab9520d15c7 Chandrashekar Devegowda 2025-06-10  2454  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2026-04-14  0:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14  0:26 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-04-13  4:20 [PATCH v3] Bluetooth: btintel_pcie: Support Product level reset Chandrashekar Devegowda
2026-04-13 20:00 ` patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202604140816.wm7rA2AH-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.