From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Carlos Maiolino <cem@kernel.org>,
Damien Le Moal <dlemoal@kernel.org>,
linux-block@vger.kernel.org, linux-xfs@vger.kernel.org,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 4/5] block: add a bio_submit_or_kill helper
Date: Tue, 14 Apr 2026 10:24:08 +0200 [thread overview]
Message-ID: <20260414082408.GA11656@lst.de> (raw)
In-Reply-To: <b2e8e413-39bf-4255-8aad-a30d7fd676ea@acm.org>
On Tue, Apr 07, 2026 at 11:37:50AM -0700, Bart Van Assche wrote:
> Without this change, if a fatal signal is pending before the loop starts,
> -EINTR is returned. With this patch applied, 0 is returned,
> isn't it?
I looked at this a bit, and it turns that while this indeed changes the
behavior for discard, the other ioctls had the return 0 when nothing
was submitted before the thread got killed behavior, and this makes
discard match them.
Given that we won't return from the system call for a fatal kill it
should not matter. Adding Keith who wrote all this to confirm.
next prev parent reply other threads:[~2026-04-14 8:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 14:05 refactor submit_bio_wait and bio await helpers v3 Christoph Hellwig
2026-04-07 14:05 ` [PATCH 1/5] xfs: fix number of GC bvecs Christoph Hellwig
2026-04-07 14:05 ` [PATCH 2/5] block: unify the synchronous bi_end_io callbacks Christoph Hellwig
2026-04-08 7:56 ` Chaitanya Kulkarni
2026-04-07 14:05 ` [PATCH 3/5] block: factor out a bio_await helper Christoph Hellwig
2026-04-07 14:59 ` Bart Van Assche
2026-04-08 5:11 ` Christoph Hellwig
2026-04-07 14:05 ` [PATCH 4/5] block: add a bio_submit_or_kill helper Christoph Hellwig
2026-04-07 15:04 ` Bart Van Assche
2026-04-07 18:37 ` Bart Van Assche
2026-04-08 5:16 ` Christoph Hellwig
2026-04-14 8:24 ` Christoph Hellwig [this message]
2026-04-07 14:05 ` [PATCH 5/5] xfs: use bio_await in xfs_zone_gc_reset_sync Christoph Hellwig
2026-04-08 7:57 ` Chaitanya Kulkarni
2026-04-07 14:22 ` refactor submit_bio_wait and bio await helpers v3 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260414082408.GA11656@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=cem@kernel.org \
--cc=dlemoal@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.