All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thorsten Blum <thorsten.blum@linux.dev>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>
Cc: Thorsten Blum <thorsten.blum@linux.dev>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] crypto: blake2s - use memcpy_and_pad in __blake2s_init
Date: Tue, 14 Apr 2026 17:49:04 +0200	[thread overview]
Message-ID: <20260414154902.344182-4-thorsten.blum@linux.dev> (raw)
In-Reply-To: <20260414154902.344182-3-thorsten.blum@linux.dev>

Use memcpy_and_pad() instead of memcpy() followed by memset() to
simplify __blake2s_init(). Use sizeof(ctx->buf) instead of the macro
BLAKE2S_BLOCK_SIZE.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 include/crypto/blake2s.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/include/crypto/blake2s.h b/include/crypto/blake2s.h
index 648cb7824358..f0e0ce0b30a5 100644
--- a/include/crypto/blake2s.h
+++ b/include/crypto/blake2s.h
@@ -70,9 +70,8 @@ static inline void __blake2s_init(struct blake2s_ctx *ctx, size_t outlen,
 	ctx->buflen = 0;
 	ctx->outlen = outlen;
 	if (keylen) {
-		memcpy(ctx->buf, key, keylen);
-		memset(&ctx->buf[keylen], 0, BLAKE2S_BLOCK_SIZE - keylen);
-		ctx->buflen = BLAKE2S_BLOCK_SIZE;
+		memcpy_and_pad(ctx->buf, sizeof(ctx->buf), key, keylen, 0);
+		ctx->buflen = sizeof(ctx->buf);
 	}
 }
 

  reply	other threads:[~2026-04-14 15:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14 15:49 [PATCH 1/2] crypto: blake2b - use memcpy_and_pad in __blake2b_init Thorsten Blum
2026-04-14 15:49 ` Thorsten Blum [this message]
2026-04-14 17:39   ` [PATCH 2/2] crypto: blake2s - use memcpy_and_pad in __blake2s_init Eric Biggers
2026-04-15 12:56     ` Thorsten Blum
2026-04-15 17:37       ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260414154902.344182-4-thorsten.blum@linux.dev \
    --to=thorsten.blum@linux.dev \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.