Re: [RFC PATCH v1.1 1/2] mm/damon/stat: add a parameter for reading kdamond pid

[SeongJae Park <sj@kernel.org>]

On Wed, 15 Apr 2026 00:16:14 +0000 sashiko-bot@kernel.org wrote:

> Sashiko AI review found 1 potential issue(s):
> - [Low] Missing closing brace `}` in `damon_stat_start()` error path causes compilation failure.
> --
> 
> commit 04b7136ae6b7cd907673996f57f0a613de1984b9
> Author: SeongJae Park <sj@kernel.org>
> 
> mm/damon/stat: add a parameter for reading kdamond pid
> 
> This commit exposes the pid of the DAMON_STAT kdamond via a new read-only
> module parameter named kdamond_pid to help user-space management and
> monitoring.
> 
> > diff --git a/mm/damon/stat.c b/mm/damon/stat.c
> > --- a/mm/damon/stat.c
> > +++ b/mm/damon/stat.c
> 
> [ ... ]
> 
> > @@ -260,6 +269,13 @@ static int damon_stat_start(void)
> >  		damon_stat_context = NULL;
> >  		return err;
> >  	}
> > +	kdamond_pid = damon_kdamond_pid(damon_stat_context);
> > +	if (kdamond_pid < 0) {
> > +		err = kdamond_pid;
> > +		kdamond_pid = -1;
> > +		damon_destroy_ctx(damon_stat_context);
> > +		damon_stat_context = NULL;
> > +		return err;
> 
> Is there a missing closing brace for the if (kdamond_pid < 0) block here?
> It looks like the omission will swallow the rest of the function into the
> error path and cause a compilation failure.

Good eye.  I will fix this in the next revision.


Thanks,
SJ

[...]