From: Heiko Carstens <hca@linux.ibm.com>
To: Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
mathieu.desnoyers@efficios.com,
Mark Rutland <mark.rutland@arm.com>,
cmarinas@kernel.org, maddy@linux.ibm.com, ryan.roberts@arm.com
Subject: Re: [RFC] in-kernel rseq
Date: Wed, 15 Apr 2026 10:51:31 +0200 [thread overview]
Message-ID: <20260415085131.10321Abf-hca@linux.ibm.com> (raw)
In-Reply-To: <f91f61aa-ef41-4109-8bd1-723d11c9a490@linux.ibm.com>
On Fri, Apr 10, 2026 at 11:27:50PM +0530, Shrikanth Hegde wrote:
> Hi Peter,
>
> On 2/23/26 10:08 PM, Peter Zijlstra wrote:
> > Hi,
> >
> > It has come to my attention that various people are struggling with
> > preempt_disable()+preempt_enable() costs for various architectures.
> >
> > Mostly in relation to things like this_cpu_ and or local_.
> >
> > The below is a very crude (and broken, more on that below) POC.
> >
> > So the 'main' advantage of this over preempt_disable()/preempt_enable(),
> > it on the preempt_enable() side, this elides the whole conditional and
> > call schedule() nonsense.
>
> This might be a very stupid question.
>
> Why not just call preempt_enable_no_resched instead?
>
> this_cpu operations would have disabled preemption so the per_cpu
> structures are protected from thread migration right? intention
> here is likely not to call schedule. No?
Doing that would make it unpredictable when the kernel is preempted for
cases where TIF_PREEMPT is set while within a code section which has
preemption disabled and where preemption is enabled again without checking
for TIF_PREEMPT.
next prev parent reply other threads:[~2026-04-15 8:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 16:38 [RFC] in-kernel rseq Peter Zijlstra
2026-02-23 17:53 ` David Laight
2026-02-23 18:22 ` Mathieu Desnoyers
2026-02-23 21:54 ` Peter Zijlstra
2026-02-24 10:27 ` David Laight
2026-02-24 13:33 ` Mathieu Desnoyers
2026-02-24 14:49 ` David Laight
2026-02-24 16:15 ` Mathieu Desnoyers
2026-02-24 11:16 ` Heiko Carstens
2026-02-24 13:48 ` Mathieu Desnoyers
2026-02-24 14:59 ` David Laight
2026-02-24 16:18 ` Mathieu Desnoyers
2026-02-24 15:17 ` Peter Zijlstra
2026-02-24 15:20 ` Peter Zijlstra
2026-02-24 16:02 ` Heiko Carstens
2026-02-24 16:15 ` Heiko Carstens
2026-04-10 17:57 ` Shrikanth Hegde
2026-04-15 8:51 ` Heiko Carstens [this message]
2026-04-17 9:29 ` Shrikanth Hegde
2026-04-17 9:36 ` Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260415085131.10321Abf-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=cmarinas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=peterz@infradead.org \
--cc=ryan.roberts@arm.com \
--cc=sshegde@linux.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.