All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Anton Danilov <littlesmilingcloud@gmail.com>
Cc: Breno Leitao <leitao@debian.org>,
	netdev@vger.kernel.org, willemdebruijn.kernel@gmail.com,
	davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
	pabeni@redhat.com, horms@kernel.org, shuah@kernel.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [RFC PATCH net-next 2/2] selftests: net: add FOU multicast encapsulation resubmit test
Date: Wed, 15 Apr 2026 09:18:00 -0700	[thread overview]
Message-ID: <20260415091800.4ee4d744@kernel.org> (raw)
In-Reply-To: <ad9hkJXAnlv2ZUm6@gmail.com>

On Wed, 15 Apr 2026 03:25:59 -0700 Breno Leitao wrote:
> On Wed, Apr 15, 2026 at 02:28:06AM +0300, Anton Danilov wrote:
> > +send_fou_gre_packets() {
> > +	local count=$1
> > +
> > +	ip netns exec "$NSENDER" python3 -c "  
> 
> Having Python code embedded directly in the shell function makes this
> difficult to review and maintain. Could you extract the Python script to
> a separate file? This would simplify the code to just:
> 
> 	ip netns exec "$NSENDER" python3 my_python_script.py

Or just rewrite the whole thing in Python (no preference)

      reply	other threads:[~2026-04-15 16:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14 23:24 [RFC PATCH net-next 0/2] udp: fix FOU/GUE over multicast Anton Danilov
2026-04-14 23:27 ` [RFC PATCH net-next 1/2] udp: fix encapsulation packet resubmit in multicast deliver Anton Danilov
2026-04-14 23:28 ` [RFC PATCH net-next 2/2] selftests: net: add FOU multicast encapsulation resubmit test Anton Danilov
2026-04-15 10:25   ` Breno Leitao
2026-04-15 16:18     ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260415091800.4ee4d744@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=littlesmilingcloud@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.