From: Jamin Lin <jamin_lin@aspeedtech.com>
To: "philmd@linaro.org" <philmd@linaro.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Kane Chen" <kane_chen@aspeedtech.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: Jamin Lin <jamin_lin@aspeedtech.com>,
Troy Lee <troy_lee@aspeedtech.com>,
"flwu@google.com" <flwu@google.com>,
"nabihestefan@google.com" <nabihestefan@google.com>
Subject: [PATCH v3 15/17] hw/arm/aspeed_ast27x0: Set EHCI descriptor address offset
Date: Thu, 16 Apr 2026 01:50:01 +0000 [thread overview]
Message-ID: <20260416014928.1279360-16-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20260416014928.1279360-1-jamin_lin@aspeedtech.com>
On AST2700 platforms, system DRAM is mapped above 4GB with the
base address at 0x400000000.
The Linux EHCI driver programs the segment register to zero when
64-bit addressing is supported. As a result, descriptor addresses
derived from the EHCI registers do not include the DRAM base
address.
Descriptor memory is allocated through the DMA API with a 64-bit
DMA mask, which allows descriptors to be placed in DRAM above 4GB.
When running on AST2700, this means EHCI queue heads (QH) and queue
element transfer descriptors (qTD) reside at addresses starting
from 0x400000000.
Set the descriptor-addr-offset property to the DRAM base so the
emulated EHCI controller can construct the correct descriptor
addresses when accessing system memory.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
hw/arm/aspeed_ast27x0.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c
index 4a1f7cad73..3cdbf78ac1 100644
--- a/hw/arm/aspeed_ast27x0.c
+++ b/hw/arm/aspeed_ast27x0.c
@@ -858,6 +858,9 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, Error **errp)
for (i = 0; i < sc->ehcis_num; i++) {
object_property_set_bool(OBJECT(&s->ehci[i]), "caps-64bit-addr", true,
&error_abort);
+ object_property_set_int(OBJECT(&s->ehci[i]), "descriptor-addr-offset",
+ sc->memmap[ASPEED_DEV_SDRAM],
+ &error_abort);
if (!sysbus_realize(SYS_BUS_DEVICE(&s->ehci[i]), errp)) {
return;
}
--
2.43.0
next prev parent reply other threads:[~2026-04-16 1:53 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 1:49 [PATCH v3 00/17] hw/usb/ehci: Add 64-bit descriptor addressing support Jamin Lin
2026-04-16 1:49 ` [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn structure and dead code Jamin Lin
2026-04-16 12:09 ` BALATON Zoltan
2026-04-17 1:16 ` Jamin Lin
2026-04-17 2:25 ` Jamin Lin
2026-04-17 9:47 ` BALATON Zoltan
2026-04-20 3:46 ` Jamin Lin
2026-04-17 6:30 ` Cédric Le Goater
2026-04-16 1:49 ` [PATCH v3 02/17] hw/usb/hcd-ehci.h: Fix coding style issues reported by checkpatch Jamin Lin
2026-04-17 6:32 ` Philippe Mathieu-Daudé
2026-04-16 1:49 ` [PATCH v3 03/17] hw/usb/hcd-ehci.c: " Jamin Lin
2026-04-17 6:31 ` Cédric Le Goater
2026-04-17 6:32 ` Philippe Mathieu-Daudé
2026-04-16 1:49 ` [PATCH v3 04/17] hw/usb/hcd-ehci.c: Replace fprintf(stderr, ...) with qemu_log_mask(LOG_GUEST_ERROR) Jamin Lin
2026-04-17 6:31 ` Philippe Mathieu-Daudé
2026-04-17 8:41 ` Jamin Lin
2026-04-16 1:49 ` [PATCH v3 05/17] hw/usb/hcd-ehci: Replace DPRINTF debug logs with trace events Jamin Lin
2026-04-17 5:04 ` Philippe Mathieu-Daudé
2026-04-16 1:49 ` [PATCH v3 06/17] hw/usb/hcd-ehci: Change descriptor addresses to 64-bit Jamin Lin
2026-04-17 4:54 ` Philippe Mathieu-Daudé
2026-04-17 7:01 ` Cédric Le Goater
2026-04-17 15:10 ` Peter Xu
2026-04-20 5:56 ` Jamin Lin
2026-04-20 13:34 ` Peter Xu
2026-04-22 9:21 ` Jamin Lin
2026-04-22 14:37 ` Peter Xu
2026-04-23 1:48 ` Jamin Lin
2026-04-23 16:03 ` Peter Xu
2026-04-20 16:04 ` Cédric Le Goater
2026-04-22 9:10 ` Jamin Lin
2026-04-16 1:49 ` [PATCH v3 07/17] hw/usb/hcd-ehci: Add property to advertise 64-bit addressing capability Jamin Lin
2026-04-17 4:55 ` Philippe Mathieu-Daudé
2026-04-16 1:49 ` [PATCH v3 08/17] hw/usb/hcd-ehci: Reject CTRLDSSEGMENT writes without 64-bit capability Jamin Lin
2026-04-17 6:33 ` Philippe Mathieu-Daudé
2026-04-17 8:07 ` Jamin Lin
2026-04-16 1:49 ` [PATCH v3 09/17] hw/usb/hcd-ehci: Implement 64-bit QH descriptor addressing Jamin Lin
2026-04-17 5:03 ` Philippe Mathieu-Daudé
2026-04-17 5:40 ` Jamin Lin
2026-04-17 6:14 ` Philippe Mathieu-Daudé
2026-04-17 7:02 ` Jamin Lin
2026-04-16 1:49 ` [PATCH v3 10/17] hw/usb/hcd-ehci: Implement 64-bit qTD " Jamin Lin
2026-04-17 6:14 ` Philippe Mathieu-Daudé
2026-04-16 1:49 ` [PATCH v3 11/17] hw/usb/hcd-ehci: Implement 64-bit iTD " Jamin Lin
2026-04-17 6:15 ` Philippe Mathieu-Daudé
2026-04-16 1:49 ` [PATCH v3 12/17] hw/usb/hcd-ehci: Implement 64-bit siTD " Jamin Lin
2026-04-17 6:27 ` Philippe Mathieu-Daudé
2026-04-17 7:44 ` Jamin Lin
2026-04-17 8:42 ` Philippe Mathieu-Daudé
2026-04-16 1:49 ` [PATCH v3 13/17] hw/usb/hcd-ehci: Add descriptor address offset property Jamin Lin
2026-04-17 6:23 ` Philippe Mathieu-Daudé
2026-04-22 5:00 ` Jamin Lin
2026-04-17 6:45 ` Cédric Le Goater
2026-04-17 7:08 ` Philippe Mathieu-Daudé
2026-04-20 5:47 ` Jamin Lin
2026-04-20 7:08 ` Cédric Le Goater
2026-04-22 6:58 ` Jamin Lin
2026-04-16 1:50 ` [PATCH v3 14/17] hw/arm/aspeed_ast27x0: Enable 64-bit EHCI DMA addressing Jamin Lin
2026-04-17 6:23 ` Philippe Mathieu-Daudé
2026-04-16 1:50 ` Jamin Lin [this message]
2026-04-17 6:25 ` [PATCH v3 15/17] hw/arm/aspeed_ast27x0: Set EHCI descriptor address offset Philippe Mathieu-Daudé
2026-04-22 5:03 ` Jamin Lin
2026-04-16 1:50 ` [PATCH v3 16/17] tests/functional/arm/test_aspeed_ast2600_sdk: Add USB EHCI test for AST2600 SDK Jamin Lin
2026-04-17 6:27 ` Philippe Mathieu-Daudé
2026-04-17 7:40 ` Jamin Lin
2026-04-17 8:44 ` Philippe Mathieu-Daudé
2026-04-17 8:50 ` Jamin Lin
2026-04-16 1:50 ` [PATCH v3 17/17] tests/functional/aarch64/test_aspeed_ast2700: Add USB EHCI test for AST2700 A1/A2 Jamin Lin
2026-04-17 6:27 ` Philippe Mathieu-Daudé
2026-04-17 6:35 ` [PATCH v3 00/17] hw/usb/ehci: Add 64-bit descriptor addressing support Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260416014928.1279360-16-jamin_lin@aspeedtech.com \
--to=jamin_lin@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=flwu@google.com \
--cc=joel@jms.id.au \
--cc=kane_chen@aspeedtech.com \
--cc=leetroy@gmail.com \
--cc=nabihestefan@google.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.