All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Carstens <hca@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Kevin Brodsky <kevin.brodsky@arm.com>,
	David Hildenbrand <david@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	linux-s390@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] s390/mm: Batch PTE updates in lazy MMU mode
Date: Thu, 16 Apr 2026 07:40:45 +0200	[thread overview]
Message-ID: <20260416054045.10407A20-hca@linux.ibm.com> (raw)
In-Reply-To: <924c91e711e8b16470eb2af7e31d0b6ffcf2940c.1776264097.git.agordeev@linux.ibm.com>

On Wed, Apr 15, 2026 at 05:01:23PM +0200, Alexander Gordeev wrote:
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index 7828fbe0fc42..deffc819268e 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -732,6 +732,17 @@ config MAX_PHYSMEM_BITS
>  	  Increasing the number of bits also increases the kernel image size.
>  	  By default 46 bits (64TB) are supported.
>  
> +config IPTE_BATCH
> +	def_bool y
> +	prompt "Enables Additional Entries for IPTE instruction"
> +	select ARCH_HAS_LAZY_MMU_MODE
> +	help
> +	  This option enables using of "Additional Entries" field of the IPTE
> +	  instruction, which capitalizes on the lazy MMU mode infrastructure.
> +	  As result, multiple PTEs are invalidated in one go. That improves
> +	  performance of many memory-management system calls (like mremap(),
> +	  mprotect(), etc.) and decreases CEC-wide quiesce traffic.
> +
>  endmenu

Just some general comments before I find time to look deeper into this
series: please let us not add yet another config option. This will be
enabled anywhere in any case.

Not having this option makes maintenance easier.

> +#if !defined(CONFIG_IPTE_BATCH) || defined(__DECOMPRESSOR)
> +static inline
> +bool ipte_batch_ptep_test_and_clear_young(struct vm_area_struct *vma,
> +					  unsigned long addr, pte_t *ptep,
> +					  int *res)
> +{
> +	return false;
> +}

Why does this depend on __DECOMPRESSOR? Which code in the decompressor
would generate a call to the ipte_batch functions?


  reply	other threads:[~2026-04-16  5:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15 15:01 [PATCH v2 0/6] s390/mm: Batch PTE updates in lazy MMU mode Alexander Gordeev
2026-04-15 15:01 ` [PATCH v2 1/6] mm: Make lazy MMU mode context-aware Alexander Gordeev
2026-04-20  8:45   ` Kevin Brodsky
2026-04-21  4:57     ` Alexander Gordeev
2026-04-21  8:40       ` Kevin Brodsky
2026-04-21 14:12         ` David Hildenbrand (Arm)
2026-04-21 14:15   ` David Hildenbrand (Arm)
2026-04-21 14:25     ` Alexander Gordeev
2026-04-23 10:49   ` Heiko Carstens
2026-04-15 15:01 ` [PATCH v2 2/6] mm/pgtable: Fix bogus comment to clear_not_present_full_ptes() Alexander Gordeev
2026-04-16  7:58   ` David Hildenbrand (Arm)
2026-04-16  8:53     ` Alexander Gordeev
2026-04-15 15:01 ` [PATCH v2 3/6] s390/mm: Complete ptep_get() conversion Alexander Gordeev
2026-04-23 10:51   ` Heiko Carstens
2026-04-24 11:54     ` Alexander Gordeev
2026-04-24 12:34       ` Heiko Carstens
2026-04-15 15:01 ` [PATCH v2 4/6] s390/mm: Make PTC and UV call order consistent Alexander Gordeev
2026-04-23 10:54   ` Heiko Carstens
2026-04-24 11:35     ` Alexander Gordeev
2026-04-15 15:01 ` [PATCH v2 5/6] s390/mm: Batch PTE updates in lazy MMU mode Alexander Gordeev
2026-04-16  5:40   ` Heiko Carstens [this message]
2026-04-16  5:51     ` Alexander Gordeev
2026-04-23 12:28   ` Heiko Carstens
2026-04-24 13:10     ` Alexander Gordeev
2026-04-27  9:07       ` Heiko Carstens
2026-04-29  8:45     ` Alexander Gordeev
2026-04-15 15:01 ` [PATCH v2 6/6] s390/mm: Allow lazy MMU mode disabling Alexander Gordeev
2026-04-16  5:44   ` Heiko Carstens
2026-04-16  7:00     ` Alexander Gordeev
2026-04-16  8:22       ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260416054045.10407A20-hca@linux.ibm.com \
    --to=hca@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=gerald.schaefer@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kevin.brodsky@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.