All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, hans@jjverkuil.nl,
	Prabhakar <prabhakar.csengg@gmail.com>,
	"Kate Hsuan" <hpa@redhat.com>,
	"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
	"Tommaso Merciai" <tomm.merciai@gmail.com>,
	"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
	"Sylvain Petinot" <sylvain.petinot@foss.st.com>,
	"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
	"Julien Massot" <julien.massot@collabora.com>,
	"Naushir Patuck" <naush@raspberrypi.com>,
	"Yan, Dongcheng" <dongcheng.yan@intel.com>,
	"Cao, Bingbu" <bingbu.cao@intel.com>,
	"Qiu, Tian Shu" <tian.shu.qiu@intel.com>,
	"Stefan Klug" <stefan.klug@ideasonboard.com>,
	"Mirela Rabulea" <mirela.rabulea@nxp.com>,
	"André Apitzsch" <git@apitzsch.eu>,
	"Heimir Thor Sverrisson" <heimir.sverrisson@gmail.com>,
	"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
	"Mehdi Djait" <mehdi.djait@linux.intel.com>,
	"Ricardo Ribalda Delgado" <ribalda@kernel.org>,
	"Hans de Goede" <hansg@kernel.org>,
	"Jacopo Mondi" <jacopo.mondi@ideasonboard.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
	"David Plowman" <david.plowman@raspberrypi.com>,
	"Yu, Ong Hock" <ong.hock.yu@intel.com>,
	"Ng, Khai Wen" <khai.wen.ng@intel.com>,
	"Jai Luthra" <jai.luthra@ideasonboard.com>,
	"Rishikesh Donadkar" <r-donadkar@ti.com>
Subject: Re: [PATCH v4 02/29] media: imx219: Fix maximum frame length in lines
Date: Thu, 16 Apr 2026 16:56:34 +0300	[thread overview]
Message-ID: <20260416135634.GC1775831@killaraus.ideasonboard.com> (raw)
In-Reply-To: <20260408153939.969381-3-sakari.ailus@linux.intel.com>

On Wed, Apr 08, 2026 at 06:39:11PM +0300, Sakari Ailus wrote:
> The driver used the maximum frame length in lines value of 0xffff, but the
> maximum appears to be 0xfffe instead. Fix it.
> 
> Fixes: 1283b3b8f82b ("media: i2c: Add driver for Sony IMX219 sensor")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> ---
>  drivers/media/i2c/imx219.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index cbd151d4af5f..89061dc1842d 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -72,7 +72,7 @@
>  
>  /* V_TIMING internal */
>  #define IMX219_REG_FRM_LENGTH_A		CCI_REG16(0x0160)
> -#define IMX219_FLL_MAX			0xffff
> +#define IMX219_FLL_MAX			0xfffe
>  #define IMX219_VBLANK_MIN		32
>  #define IMX219_REG_LINE_LENGTH_A	CCI_REG16(0x0162)
>  #define IMX219_LLP_MIN			0x0d78

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2026-04-16 13:56 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08 15:39 [PATCH v4 00/29] Metadata series preparation Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 01/29] media: imx219: Rename "PIXEL_ARRAY" as "VISIBLE" Sakari Ailus
2026-04-16 13:14   ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 02/29] media: imx219: Fix maximum frame length in lines Sakari Ailus
2026-04-16 13:56   ` Laurent Pinchart [this message]
2026-04-08 15:39 ` [PATCH v4 03/29] media: imx219: Set horizontal blanking on mode change Sakari Ailus
2026-04-10  7:27   ` Jacopo Mondi
2026-04-16 14:22     ` Laurent Pinchart
2026-04-16 14:38     ` Dave Stevenson
2026-04-08 15:39 ` [PATCH v4 04/29] media: imx219: Scale the vblank limits according to rate_factor Sakari Ailus
2026-04-10  8:28   ` Jacopo Mondi
2026-04-10  8:41     ` Sakari Ailus
2026-04-10  9:01       ` Jacopo Mondi
2026-04-20 21:08         ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 05/29] media: imx219: Fix vertical blanking and exposure for analogue binning Sakari Ailus
2026-04-10  8:42   ` Jacopo Mondi
2026-04-10  8:46     ` Sakari Ailus
2026-04-10  8:56       ` Jacopo Mondi
2026-04-10  9:04         ` Sakari Ailus
2026-04-10 13:38           ` Jacopo Mondi
2026-04-15 14:38     ` Jai Luthra
2026-04-20 21:02       ` Sakari Ailus
2026-04-15 17:15   ` Jai Luthra
2026-04-20 20:54     ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 06/29] media: imx219: Don't update exposure limits while setting format Sakari Ailus
2026-04-10  8:44   ` Jacopo Mondi
2026-04-10 10:14     ` Sakari Ailus
2026-04-10 10:29     ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 07/29] media: imx219: Rename "binning" as "bin_hv" in imx219_set_pad_format Sakari Ailus
2026-04-16 14:25   ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 08/29] media: imx274: Remove redundant kernel-doc comments Sakari Ailus
2026-04-10  8:48   ` Jacopo Mondi
2026-04-10  8:54     ` Sakari Ailus
2026-04-10  9:02       ` Jacopo Mondi
2026-04-16 14:26   ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 09/29] media: imx334: " Sakari Ailus
2026-04-10  9:02   ` Jacopo Mondi
2026-04-16 14:27   ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 10/29] media: imx335: " Sakari Ailus
2026-04-10  9:02   ` Jacopo Mondi
2026-04-16 14:27   ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 11/29] media: imx412: " Sakari Ailus
2026-04-10  9:03   ` Jacopo Mondi
2026-04-16 14:28   ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 12/29] media: ov9282: " Sakari Ailus
2026-04-10  9:08   ` Jacopo Mondi
2026-04-16 14:28   ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 13/29] media: tvp514x: " Sakari Ailus
2026-04-10  9:08   ` Jacopo Mondi
2026-04-16 14:28   ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 14/29] media: Documentation: Improve LINK_FREQ documentation Sakari Ailus
2026-04-16 15:05   ` Laurent Pinchart
2026-04-21 14:42     ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 15/29] media: Documentation: Improve pixel rate calculation documentation Sakari Ailus
2026-04-16 16:20   ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 16/29] media: v4l2-subdev: Refactor returning routes Sakari Ailus
2026-04-16 16:24   ` Laurent Pinchart
2026-04-21 14:50     ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 17/29] media: v4l2-subdev: Allow accessing routes with STREAMS client capability Sakari Ailus
2026-04-16 15:06   ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 18/29] media: mc: Simplify link processing in __media_pipeline_start() Sakari Ailus
2026-04-10  9:26   ` Jacopo Mondi
2026-04-16 14:35   ` Laurent Pinchart
2026-04-21 10:24     ` Sakari Ailus
2026-04-21 11:18       ` Laurent Pinchart
2026-04-21 12:37         ` Sakari Ailus
2026-04-21 22:10           ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 19/29] media: mc: Separate single link validation into a new function Sakari Ailus
2026-04-10  9:29   ` Jacopo Mondi
2026-04-16 16:35   ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 20/29] media: uapi: Bump the STREAMS bit a little Sakari Ailus
2026-04-10  9:31   ` Jacopo Mondi
2026-04-16 14:31     ` Laurent Pinchart
2026-04-21 10:27       ` Sakari Ailus
2026-04-21 11:18         ` Laurent Pinchart
2026-05-05  6:33   ` Hans Verkuil
2026-05-05  6:47     ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 21/29] media: mc: Don't care about unsettable flags in MEDIA_IOC_LINK_SETUP Sakari Ailus
2026-04-10 10:31   ` Jacopo Mondi
2026-04-10 12:56     ` Sakari Ailus
2026-04-10 13:24       ` Jacopo Mondi
2026-04-16 15:59   ` Laurent Pinchart
2026-04-21 10:44     ` Sakari Ailus
2026-05-05  6:36   ` Hans Verkuil
2026-05-05  6:51     ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 22/29] media: mc: Add MEDIA_LNK_FL_VALIDATE_LATE Sakari Ailus
2026-04-10 10:41   ` Jacopo Mondi
2026-04-13  7:59     ` Sakari Ailus
2026-04-13  9:30       ` Jacopo Mondi
2026-04-16 16:29   ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 23/29] media: Improve enable_streams and disable_streams documentation Sakari Ailus
2026-04-16 15:49   ` Laurent Pinchart
2026-04-21 15:35     ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 24/29] media: v4l2-subdev: Introduce v4l2_subdev_get_frame_desc() Sakari Ailus
2026-04-10 10:53   ` Jacopo Mondi
2026-04-13  8:07     ` Sakari Ailus
2026-04-16 16:16       ` Laurent Pinchart
2026-04-21 12:18         ` Sakari Ailus
2026-04-21 22:18           ` Laurent Pinchart
2026-04-22  8:26             ` Sakari Ailus
2026-04-22  9:02               ` Laurent Pinchart
2026-04-22 10:02                 ` Sakari Ailus
2026-04-22 10:47                   ` Laurent Pinchart
2026-04-22 10:48                     ` Sakari Ailus
2026-04-22 10:54                       ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 25/29] media: v4l2-subdev: Move subdev client capabilities into a new struct Sakari Ailus
2026-04-10 13:31   ` Jacopo Mondi
2026-04-13  8:11     ` Sakari Ailus
2026-04-13 12:42       ` Jacopo Mondi
2026-04-16 17:30         ` Laurent Pinchart
2026-04-23  7:02           ` Jacopo Mondi
2026-04-08 15:39 ` [PATCH v4 26/29] media: v4l2-subdev: Add struct v4l2_subdev_client_info pointer to pad ops Sakari Ailus
2026-04-16 17:32   ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 27/29] media: v4l2-subdev: Add v4l2_subdev_call_ci_active_state Sakari Ailus
2026-04-16 17:38   ` Laurent Pinchart
2026-04-21 16:04     ` Sakari Ailus
2026-04-21 16:12       ` Laurent Pinchart
2026-04-21 16:34         ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 28/29] media: v4l2-subdev: Perform client info changes to i2c drivers Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 29/29] media: v4l2-subdev: Add struct v4l2_subdev_client_info argument to pad ops Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260416135634.GC1775831@killaraus.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=benjamin.mugnier@foss.st.com \
    --cc=bingbu.cao@intel.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=david.plowman@raspberrypi.com \
    --cc=dongcheng.yan@intel.com \
    --cc=git@apitzsch.eu \
    --cc=hans@jjverkuil.nl \
    --cc=hansg@kernel.org \
    --cc=heimir.sverrisson@gmail.com \
    --cc=hpa@redhat.com \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=jai.luthra@ideasonboard.com \
    --cc=julien.massot@collabora.com \
    --cc=khai.wen.ng@intel.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mehdi.djait@linux.intel.com \
    --cc=mirela.rabulea@nxp.com \
    --cc=naush@raspberrypi.com \
    --cc=ong.hock.yu@intel.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=r-donadkar@ti.com \
    --cc=ribalda@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=stefan.klug@ideasonboard.com \
    --cc=sylvain.petinot@foss.st.com \
    --cc=tian.shu.qiu@intel.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=tomm.merciai@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.