From: Lee Jones <lee@kernel.org>
To: Anj Duvnjak <avian@extremenerds.net>
Cc: linux-input@vger.kernel.org, benjamin.tissoires@redhat.com,
jikos@kernel.org, Oleksandr Natalenko <oleksandr@natalenko.name>
Subject: Re: [PATCH v2] HID: core: downgrade short report warning to debug level
Date: Thu, 16 Apr 2026 15:44:36 +0100 [thread overview]
Message-ID: <20260416144436.GB10076@google.com> (raw)
In-Reply-To: <20260414230017.30217-1-avian@extremenerds.net>
On Wed, 15 Apr 2026, Anj Duvnjak wrote:
> Commit 0a3fe972a7cb ("HID: core: Mitigate potential OOB by removing bogus
> memset()") replaced the silent memset() with hid_warn_ratelimited(), which
> causes dmesg flooding on devices that legitimately send short reports,
> such as the APC UPS (051D:0002).
>
> Downgrade to hid_dbg_ratelimited() to restore the previous behaviour of
> only reporting under HID_DEBUG, while preserving the security fix of
> removing the bogus memset() and keeping rate limiting in place.
>
> Fixes: 0a3fe972a7cb14 ("HID: core: Mitigate potential OOB by removing bogus memset()")
> Reported-by: Anj Duvnjak <avian@extremenerds.net>
That's weird. You reported it to yourself?
> Link: https://lore.kernel.org/linux-input/MW5PR84MB135613E7947113897DD9FDA4C7272@MW5PR84MB1356.NAMPRD84.PROD.OUTLOOK.COM/
> Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
> Link: https://lore.kernel.org/linux-input/6256259.lOV4Wx5bFT@natalenko.name/
> Signed-off-by: Anj Duvnjak <avian@extremenerds.net>
> ---
> drivers/hid/hid-core.c | 4 ++--
Anyway, thanks for your efforts, but this fix appears to be superseded by:
https://lore.kernel.org/all/20260415-wip-fix-core-v1-1-ed3c4c823175@kernel.org/
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2026-04-16 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 23:00 [PATCH v2] HID: core: downgrade short report warning to debug level Anj Duvnjak
2026-04-15 7:42 ` Oleksandr Natalenko
2026-04-16 14:44 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260416144436.GB10076@google.com \
--to=lee@kernel.org \
--cc=avian@extremenerds.net \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=oleksandr@natalenko.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.