All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ajith P V <ajithpv.linux@gmail.com>
To: parthiban.veerasooran@microchip.com,
	christian.gromm@microchip.com, gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	ajithpv.linux@gmail.com
Subject: [PATCH] staging: most: video: replace BUG_ON() in comp_exit
Date: Thu, 16 Apr 2026 16:33:34 +0000	[thread overview]
Message-ID: <20260416163334.80699-1-ajithpv.linux@gmail.com> (raw)

Replace BUG_ON() with WARN_ON() and pr_err inside comp_exit().

BUG_ON() is risky and not recommended to use in kernel.
It should replace with proper handlers such as WARN()-family
(see Documentation/process/deprecated.rst).

Signed-off-by: Ajith P V <ajithpv.linux@gmail.com>
---
 drivers/staging/most/video/video.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
index 04351f8ccccf..78cbf367c308 100644
--- a/drivers/staging/most/video/video.c
+++ b/drivers/staging/most/video/video.c
@@ -577,7 +577,8 @@ static void __exit comp_exit(void)
 
 	most_deregister_configfs_subsys(&comp);
 	most_deregister_component(&comp);
-	BUG_ON(!list_empty(&video_devices));
+	if (WARN_ON(!list_empty(&video_devices)))
+		pr_err("video_devices list not empty during module exit\n");
 }
 
 module_init(comp_init);
-- 
2.43.0


             reply	other threads:[~2026-04-16 16:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16 16:33 Ajith P V [this message]
2026-04-26 18:47 ` [PATCH] staging: most: video: replace BUG_ON() in comp_exit Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260416163334.80699-1-ajithpv.linux@gmail.com \
    --to=ajithpv.linux@gmail.com \
    --cc=christian.gromm@microchip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=parthiban.veerasooran@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.