Re: [LTP] [PATCH] include/lapi: add leaf Makefile

[Petr Vorel <pvorel@suse.cz>]

Hi Jinseok,

> Hi,

> Thanks for the review!
Yw.

> If we switch to generic_trunk, the current directory is not checked;
> only subdirectories are traversed.

FYI by this I meant this change (part of more changes stated previously):

diff --git include/Makefile include/Makefile
index 6b31b046e4..84cd4ed6e3 100644
--- include/Makefile
+++ include/Makefile
@@ -24,4 +24,4 @@ ac-maintainer-clean:: ac-clean

 vpath %.h $(abs_srcdir)

-include $(top_srcdir)/include/mk/generic_leaf_target.mk
+include $(top_srcdir)/include/mk/generic_trunk_target.mk

> For example, running `make check` in include/ will descend into
> include/lapi, and running `make check` in include/lapi will descend
> into include/lapi/syscalls.

And with that change make check in include works:

ltp/include $ make check-tst_fs.h
CHECK include/tst_fs.h
tst_fs.h:83: CHECK: 'swtich' may be misspelled - perhaps 'switch'?
tst_fs.h:157: WARNING: please, no spaces at the start of a line
tst_fs.h:157: WARNING: Prefer __printf(1, 2) over __attribute__((format(printf, 1, 2)))
make: [../include/mk/rules.mk:69: check-tst_fs.h] Error 1 (ignored)

ltp/include/lapi $ make check-tls.h
CHECK include/lapi/tls.h
tls.h:1: WARNING: Improper SPDX comment style for 'tls.h', please use '/*' instead
tls.h:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
tls.h:35: WARNING: do not add new typedefs
tls.h:49: WARNING: Missing a blank line after declarations
tls.h:56: WARNING: Missing a blank line after declarations
make: [../../include/mk/rules.mk:69: check-tls.h] Error 1 (ignored)

Kind regards,
Petr

> Thanks,
> Jinseok.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp