All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
Cc: Denis Lyulin <lyulin.2003@mail.ru>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
	dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH 1/1] net/bnxt: fix string bounds checks and format specifiers
Date: Fri, 17 Apr 2026 10:03:57 -0700	[thread overview]
Message-ID: <20260417100357.7ef0dd36@phoenix.local> (raw)
In-Reply-To: <CA+BST0=Ntw_W_57uZ7DqLLFhxs9fvFsGBOiKGiZvy7GFwwubHA@mail.gmail.com>

On Fri, 17 Apr 2026 12:43:07 -0400
Kishore Padmanabha <kishore.padmanabha@broadcom.com> wrote:

> > diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> > b/drivers/net/bnxt/bnxt_ethdev.c
> > index b677f9491d..bb02a2579b 100644
> > --- a/drivers/net/bnxt/bnxt_ethdev.c
> > +++ b/drivers/net/bnxt/bnxt_ethdev.c
> > @@ -652,8 +652,9 @@ static int bnxt_init_fc_ctx_mem(struct bnxt *bp)
> >
> >         max_fc = bp->flow_stat->max_fc;
> >
> > -       sprintf(type, "bnxt_rx_fc_in_" PCI_PRI_FMT, pdev->addr.domain,
> > -               pdev->addr.bus, pdev->addr.devid, pdev->addr.function);
> > +       snprintf(type, RTE_MEMZONE_NAMESIZE, "bnxt_rx_fc_in_" PCI_PRI_FMT,
> > +               pdev->addr.domain, pdev->addr.bus,
> > +               pdev->addr.devid, pdev->addr.function);
> >         /* 4 bytes for each counter-id */

Rather than silently truncating, it should return an error.

  reply	other threads:[~2026-04-17 17:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17  4:56 [PATCH 1/1] net/bnxt: fix string bounds checks and format specifiers Denis Lyulin
2026-04-17 16:43 ` Kishore Padmanabha
2026-04-17 17:03   ` Stephen Hemminger [this message]
2026-04-22  4:44     ` Re[2]: " Денис Люлин
2026-04-22 13:35       ` Kishore Padmanabha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260417100357.7ef0dd36@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=kishore.padmanabha@broadcom.com \
    --cc=lyulin.2003@mail.ru \
    --cc=sriharsha.basavapatna@broadcom.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.