All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
	"Mike Rapoport" <rppt@kernel.org>,
	"Rich Felker" <dalias@libc.org>,
	"Thomas Wei�schuh" <thomas.weissschuh@linutronix.de>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org
Subject: [PATCH] sh: fix fallout from ZERO_PAGE consolidation
Date: Fri, 17 Apr 2026 13:32:07 +0300	[thread overview]
Message-ID: <20260417103208.1217010-1-rppt@kernel.org> (raw)

From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>

Consolidation of empty_zero_page declarations broke boot on sh.

sh stores its initial boot parameters in a page reserved in
arch/sh/kernel/head_32.S. Before commit 6215d9f4470f ("arch, mm:
consolidate empty_zero_page") this page was referenced in C code as an
array and after that commit it is referenced as a pointer.

This causes wrong code generation and boot hang.

Declare boot_params_page as an array to fix the issue.

Reported-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Tested-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Fixes: 6215d9f4470f ("arch, mm: consolidate empty_zero_page")
Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
---
 arch/sh/include/asm/setup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sh/include/asm/setup.h b/arch/sh/include/asm/setup.h
index 63c9efc06348..8488f76b48b4 100644
--- a/arch/sh/include/asm/setup.h
+++ b/arch/sh/include/asm/setup.h
@@ -7,7 +7,7 @@
 /*
  * This is set up by the setup-routine at boot-time
  */
-extern unsigned char *boot_params_page;
+extern unsigned char boot_params_page[];
 #define PARAM boot_params_page
 
 #define MOUNT_ROOT_RDONLY (*(unsigned long *) (PARAM+0x000))

base-commit: 43cfbdda5af60ffc6272a7b8c5c37d1d0a181ca9
-- 
2.53.0


             reply	other threads:[~2026-04-17 10:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17 10:32 Mike Rapoport [this message]
2026-04-17 10:56 ` [PATCH] sh: fix fallout from ZERO_PAGE consolidation John Paul Adrian Glaubitz
2026-04-18  8:33   ` John Paul Adrian Glaubitz
2026-04-18 10:34     ` Mike Rapoport
2026-04-18 11:26       ` John Paul Adrian Glaubitz
2026-04-28 12:55         ` Andrew Morton
2026-04-28 13:20           ` John Paul Adrian Glaubitz
2026-04-28 15:01             ` Andrew Morton
2026-05-03 14:32               ` John Paul Adrian Glaubitz
2026-04-19 18:54 ` Artur Rojek
2026-04-28 12:18 ` Geert Uytterhoeven
2026-04-28 12:50   ` John Paul Adrian Glaubitz
2026-05-03 14:34 ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260417103208.1217010-1-rppt@kernel.org \
    --to=rppt@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=dalias@libc.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.