From: Simon Horman <horms@kernel.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v7 0/5] netem: bug fixes
Date: Fri, 17 Apr 2026 17:02:08 +0100 [thread overview]
Message-ID: <20260417160208.GG31784@horms.kernel.org> (raw)
In-Reply-To: <20260415142822.133241-1-stephen@networkplumber.org>
On Wed, Apr 15, 2026 at 07:27:03AM -0700, Stephen Hemminger wrote:
> These bugs were found when doing AI assisted review of sch_netem.c
> during investigation of the packet duplication recursion problem
> addressed in Jamal's series.
>
> The fixes cover:
>
> - probability gaps in the 4-state Markov loss model
> - queue limit not accounting for reordered packets
> - PRNG reseeded on every tc change, breaking reproducibility
> - slot delay configuration not validated for inverted ranges
> - slot delay arithmetic overflow for ranges above ~2.1 seconds
>
> v7 - queue limit check Fixes: goes back further to earlier change
> - use NL_SET_ERR_MSG_ATTR
>
> Stephen Hemminger (5):
> net/sched: netem: fix probability gaps in 4-state loss model
> net/sched: netem: fix queue limit check to include reordered packets
> net/sched: netem: only reseed PRNG when seed is explicitly provided
> net/sched: netem: check for invalid slot range
> net/sched: netem: fix slot delay calculation overflow
To the maintainers: I'd like to ask for more time to complete review of this.
prev parent reply other threads:[~2026-04-17 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 14:27 [PATCH v7 0/5] netem: bug fixes Stephen Hemminger
2026-04-15 14:27 ` [PATCH v7 1/5] net/sched: netem: fix probability gaps in 4-state loss model Stephen Hemminger
2026-04-15 14:27 ` [PATCH v7 2/5] net/sched: netem: fix queue limit check to include reordered packets Stephen Hemminger
2026-04-15 14:27 ` [PATCH v7 3/5] net/sched: netem: only reseed PRNG when seed is explicitly provided Stephen Hemminger
2026-04-15 14:27 ` [PATCH v7 4/5] net/sched: netem: check for invalid slot range Stephen Hemminger
2026-04-15 14:27 ` [PATCH v7 5/5] net/sched: netem: fix slot delay calculation overflow Stephen Hemminger
2026-04-17 16:02 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260417160208.GG31784@horms.kernel.org \
--to=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.