From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,skhawaja@google.com,rppt@kernel.org,pratyush@kernel.org,dmatlack@google.com,pasha.tatashin@soleen.com,akpm@linux-foundation.org
Subject: [merged mm-stable] liveupdate-protect-flb-lists-with-luo_register_rwlock.patch removed from -mm tree
Date: Sat, 18 Apr 2026 00:53:03 -0700 [thread overview]
Message-ID: <20260418075307.68684C19424@smtp.kernel.org> (raw)
The quilt patch titled
Subject: liveupdate: protect FLB lists with luo_register_rwlock
has been removed from the -mm tree. Its filename was
liveupdate-protect-flb-lists-with-luo_register_rwlock.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Pasha Tatashin <pasha.tatashin@soleen.com>
Subject: liveupdate: protect FLB lists with luo_register_rwlock
Date: Fri, 27 Mar 2026 03:33:28 +0000
Because liveupdate FLB objects will soon drop their persistent module
references when registered, list traversals must be protected against
concurrent module unloading.
To provide this protection, utilize the global luo_register_rwlock. It
protects the global registry of FLBs and the handler's specific list of
FLB dependencies.
Read locks are used during concurrent list traversals (e.g., during
preservation and serialization). Write locks are taken during
registration and unregistration.
Link: https://lore.kernel.org/20260327033335.696621-5-pasha.tatashin@soleen.com
Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Reviewed-by: Pratyush Yadav (Google) <pratyush@kernel.org>
Cc: David Matlack <dmatlack@google.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Samiullah Khawaja <skhawaja@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/liveupdate.h | 1 +
kernel/liveupdate/luo_flb.c | 14 ++++++++++++++
2 files changed, 15 insertions(+)
--- a/include/linux/liveupdate.h~liveupdate-protect-flb-lists-with-luo_register_rwlock
+++ a/include/linux/liveupdate.h
@@ -12,6 +12,7 @@
#include <linux/kho/abi/luo.h>
#include <linux/list.h>
#include <linux/mutex.h>
+#include <linux/rwsem.h>
#include <linux/types.h>
#include <uapi/linux/liveupdate.h>
--- a/kernel/liveupdate/luo_flb.c~liveupdate-protect-flb-lists-with-luo_register_rwlock
+++ a/kernel/liveupdate/luo_flb.c
@@ -245,17 +245,20 @@ int luo_flb_file_preserve(struct liveupd
struct luo_flb_link *iter;
int err = 0;
+ down_read(&luo_register_rwlock);
list_for_each_entry(iter, flb_list, list) {
err = luo_flb_file_preserve_one(iter->flb);
if (err)
goto exit_err;
}
+ up_read(&luo_register_rwlock);
return 0;
exit_err:
list_for_each_entry_continue_reverse(iter, flb_list, list)
luo_flb_file_unpreserve_one(iter->flb);
+ up_read(&luo_register_rwlock);
return err;
}
@@ -277,6 +280,7 @@ void luo_flb_file_unpreserve(struct live
struct list_head *flb_list = &ACCESS_PRIVATE(fh, flb_list);
struct luo_flb_link *iter;
+ guard(rwsem_read)(&luo_register_rwlock);
list_for_each_entry_reverse(iter, flb_list, list)
luo_flb_file_unpreserve_one(iter->flb);
}
@@ -297,6 +301,7 @@ void luo_flb_file_finish(struct liveupda
struct list_head *flb_list = &ACCESS_PRIVATE(fh, flb_list);
struct luo_flb_link *iter;
+ guard(rwsem_read)(&luo_register_rwlock);
list_for_each_entry_reverse(iter, flb_list, list)
luo_flb_file_finish_one(iter->flb);
}
@@ -360,6 +365,8 @@ int liveupdate_register_flb(struct liveu
if (!luo_session_quiesce())
return -EBUSY;
+ down_write(&luo_register_rwlock);
+
/* Check that this FLB is not already linked to this file handler */
err = -EEXIST;
list_for_each_entry(iter, flb_list, list) {
@@ -401,11 +408,13 @@ int liveupdate_register_flb(struct liveu
private->users++;
link->flb = flb;
list_add_tail(&no_free_ptr(link)->list, flb_list);
+ up_write(&luo_register_rwlock);
luo_session_resume();
return 0;
err_resume:
+ up_write(&luo_register_rwlock);
luo_session_resume();
return err;
}
@@ -449,6 +458,8 @@ int liveupdate_unregister_flb(struct liv
if (!luo_session_quiesce())
return -EBUSY;
+ down_write(&luo_register_rwlock);
+
/* Find and remove the link from the file handler's list */
list_for_each_entry(iter, flb_list, list) {
if (iter->flb == flb) {
@@ -473,11 +484,13 @@ int liveupdate_unregister_flb(struct liv
module_put(flb->ops->owner);
}
+ up_write(&luo_register_rwlock);
luo_session_resume();
return 0;
err_resume:
+ up_write(&luo_register_rwlock);
luo_session_resume();
return err;
}
@@ -643,6 +656,7 @@ void luo_flb_serialize(void)
struct liveupdate_flb *gflb;
int i = 0;
+ guard(rwsem_read)(&luo_register_rwlock);
list_private_for_each_entry(gflb, &luo_flb_global.list, private.list) {
struct luo_flb_private *private = luo_flb_get_private(gflb);
_
Patches currently in -mm which might be from pasha.tatashin@soleen.com are
liveupdate-fix-return-value-on-session-allocation-failure.patch
reply other threads:[~2026-04-18 7:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260418075307.68684C19424@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=dmatlack@google.com \
--cc=mm-commits@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
--cc=skhawaja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.