From: Jakub Kicinski <kuba@kernel.org>
To: Agalakov Daniil <ade@amicon.ru>
Cc: Jian Shen <shenjian15@huawei.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <lvc-project@linuxtesting.org>,
Roman Razov <rrv@amicon.ru>
Subject: Re: [PATCH net-next] net: hns: use u32 for register offset in RCB TX coalescing
Date: Mon, 20 Apr 2026 10:38:40 -0700 [thread overview]
Message-ID: <20260420103840.6a30683e@kernel.org> (raw)
In-Reply-To: <20260420144047.2846673-1-ade@amicon.ru>
On Mon, 20 Apr 2026 17:40:19 +0300 Agalakov Daniil wrote:
> The local variable reg in hns_rcb_get_tx_coalesced_frames() and
> hns_rcb_set_tx_coalesced_frames() holds a register offset passed to
> dsaf_read_dev()/dsaf_write_dev(). Register offsets on this hardware
> are 32-bit values; using u64 was misleading.
net-next is closed during the merge window.
If you repost please improve the "why". As is I don't think this patch
is worth merging.
prev parent reply other threads:[~2026-04-20 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 14:40 [PATCH net-next] net: hns: use u32 for register offset in RCB TX coalescing Agalakov Daniil
2026-04-20 17:38 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260420103840.6a30683e@kernel.org \
--to=kuba@kernel.org \
--cc=ade@amicon.ru \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rrv@amicon.ru \
--cc=shenjian15@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.