From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D6C0F557FE for ; Mon, 20 Apr 2026 10:45:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wEm6p-0008BH-IS; Mon, 20 Apr 2026 06:44:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wEm6n-00082Q-NZ for qemu-arm@nongnu.org; Mon, 20 Apr 2026 06:44:05 -0400 Received: from p-west3-cluster6-host5-snip4-5.eps.apple.com ([57.103.75.108] helo=outbound.ms.icloud.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wEm6m-0000ic-2q for qemu-arm@nongnu.org; Mon, 20 Apr 2026 06:44:05 -0400 Received: from outbound.ms.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-west-3a-100-percent-1 (Postfix) with ESMTPS id 29EA11800449; Mon, 20 Apr 2026 10:44:01 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr; s=sig1; t=1776681843; x=1779273843; bh=MoioDyw9WNCdgAnpil2qVwmsqi0G9SAnV0FrCmNrGIk=; h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme; b=CpGxLNp+HrrHZjrXUYKhg5ImOfQCEqfbrtnyeywqfnsgAyCOjtHN3s2y3a6vkft/ugUeldHFLi4yp4kWmgRX3rvJfK8xe/2wJ/oxQwm4XfPoEEy0jWUCZ9hWwAJm4fsnYboCOv+roDFmaMuVexuVVbBAS39t2p9Z4bHz4IEk7+Syb26JmRev8FOfhTNfsJSWqnDsMOBd6T9Xf1dUHIgDeI1c4cJzXksWhegDQDwpvOpqgKwnCDjLa3QAgtZcGdZB6oVQ3yA/RwAk8HuJ/KIwNNtHZBpkJh/y/WOG8S9wtzoGDfZlCa7+XQSgz7dlyfy0gWGEFJfw6q3wR0CnD6YhIw== mail-alias-created-date: 1752046281608 Received: from localhost.localdomain (unknown [17.57.154.37]) by p00-icloudmta-asmtp-us-west-3a-100-percent-1 (Postfix) with ESMTPSA id 9B4C71800444; Mon, 20 Apr 2026 10:43:58 +0000 (UTC) From: Mohamed Mediouni To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Mohamed Mediouni , Paolo Bonzini , Phil Dennis-Jordan , Roman Bolshakov , Pierrick Bouvier , Pedro Barbuda , Wei Liu , "Michael S. Tsirkin" , Peter Maydell , Zhao Liu Subject: [PATCH v2 27/38] target/i386: emulate: use exception_payload for fault address Date: Mon, 20 Apr 2026 12:42:37 +0200 Message-ID: <20260420104248.86702-28-mohamed@unpredictable.fr> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260420104248.86702-1-mohamed@unpredictable.fr> References: <20260420104248.86702-1-mohamed@unpredictable.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: BPMrr2-a9WCluFEdNc9SHbK75xQBDyzG X-Proofpoint-GUID: BPMrr2-a9WCluFEdNc9SHbK75xQBDyzG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIwMDEwNCBTYWx0ZWRfXys5FbfJnfK3e x9TqOurviAq3YtlJO0AJiVtwlug7JWSBXVwTzO9TkPN2IZtXaBbg2IvkzchOR6nmd7+9wEXbAGN SO/43X4GJ9zVu4M7U+2ZHPJryF5Z5fpGVl96/Ho74JdE1Rbk0z+qmDvtSQAL/it7sNbA/5bQce0 d+bnF+6RFRriibdNQeoFXpwLWrw0Fi/kcA1p886VqY0xdfcIHKugkJTqZpeGMvVH+vVM85Iapxt qbyK1AbIzBNuP+VghE8uAUpGn356m+E1hfevUBXhlmyCMKWOtT/SZrijf5T71T2npga5aFG3x2/ w97Mxx2b1drBGMBQ4jY4cWBFqye3Xhq6RPJonUdH7y1fLZzg1LhCqqdW1PvLtQ= X-Authority-Info-Out: v=2.4 cv=d7b4CBjE c=1 sm=1 tr=0 ts=69e60371 cx=c_apl:c_pps:t_out a=qkKslKyYc0ctBTeLUVfTFg==:117 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=YcyI-53RcdBlrF1VUN8A:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-20_02,2026-04-17_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=791 suspectscore=0 bulkscore=0 phishscore=0 adultscore=0 spamscore=0 malwarescore=0 clxscore=1030 lowpriorityscore=0 mlxscore=0 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2604200104 Received-SPF: pass client-ip=57.103.75.108; envelope-from=mohamed@unpredictable.fr; helo=outbound.ms.icloud.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Instead of directly putting it in cr[2], put it in exception_payload. Signed-off-by: Mohamed Mediouni --- target/i386/emulate/x86_mmu.c | 3 ++- target/i386/whpx/whpx-all.c | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/target/i386/emulate/x86_mmu.c b/target/i386/emulate/x86_mmu.c index 007de582de..8d4371467f 100644 --- a/target/i386/emulate/x86_mmu.c +++ b/target/i386/emulate/x86_mmu.c @@ -277,7 +277,8 @@ static MMUTranslateResult x86_write_mem_ex(CPUState *cpu, void *data, target_ulo translate_res = mmu_gva_to_gpa(cpu, gva, &gpa, translate_flags); if (translate_res) { int error_code = translate_res_to_error_code(translate_res, true, is_user(cpu)); - env->cr[2] = gva; + env->exception_has_payload = 1; + env->exception_payload = gva; x86_emul_raise_exception(env, EXCP0E_PAGE, error_code); return translate_res; } diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index dee2a203b2..02235d5391 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -1818,11 +1818,11 @@ static void whpx_inject_exceptions(CPUState* cpu) WHV_REGISTER_VALUE reg = {}; reg.ExceptionEvent.EventPending = 1; reg.ExceptionEvent.EventType = WHvX64PendingEventException; - reg.ExceptionEvent.DeliverErrorCode = 1; + reg.ExceptionEvent.DeliverErrorCode = env->has_error_code; reg.ExceptionEvent.Vector = env->exception_nr; reg.ExceptionEvent.ErrorCode = env->error_code; - if (env->exception_nr == EXCP0E_PAGE) { - reg.ExceptionEvent.ExceptionParameter = env->cr[2]; + if (env->exception_has_payload) { + reg.ExceptionEvent.ExceptionParameter = env->exception_payload; } whpx_set_reg(cpu, WHvRegisterPendingEvent, reg); } -- 2.50.1 (Apple Git-155)