From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8BB9F5580B for ; Mon, 20 Apr 2026 10:46:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wEm60-0006t3-MB; Mon, 20 Apr 2026 06:43:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wEm5t-0006qb-CM for qemu-arm@nongnu.org; Mon, 20 Apr 2026 06:43:10 -0400 Received: from p-west3-cluster3-host3-snip4-10.eps.apple.com ([57.103.72.181] helo=outbound.ms.icloud.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wEm5r-0000Wg-Oy for qemu-arm@nongnu.org; Mon, 20 Apr 2026 06:43:09 -0400 Received: from outbound.ms.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-west-3a-100-percent-1 (Postfix) with ESMTPS id 318CF180045A; Mon, 20 Apr 2026 10:43:04 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr; s=sig1; t=1776681786; x=1779273786; bh=LeCfULzXVq8eMeXoD4HoazACVFGuCL5m06fQgObX99k=; h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme; b=eMt0dPzoXOM74HRCiK01b4PlSpyzb82oxJxRV2sQ59yAFXu/rahQKjiQGYcwYX+VmYyWpIK5mAfdnsAsk2Wu6QM/zn2ewg1QZEIVj/qPTiLXqxO1H3NmapiNa2er77Oba4+OTwnOxFvYZGIPym/4neEmtsMN5Pt67yGXwVsdb7fWRxEuKLQ+RLYxoet7raYnh7O8kSLt89vwDfHgbpqo/gBG8kn2lKVANSZj1Bd9C+ThAIo/8TvRJ5sTSPj+GzyF6/ttc/kFQL4210WstLo1kQ8OJ2UPY5AFtDbEyxtiZ3EEu4gtIkYptHvmzaQNuBaJB2v0j5kMOUOby6ls3364PA== mail-alias-created-date: 1752046281608 Received: from localhost.localdomain (unknown [17.57.154.37]) by p00-icloudmta-asmtp-us-west-3a-100-percent-1 (Postfix) with ESMTPSA id 83EB51800466; Mon, 20 Apr 2026 10:43:01 +0000 (UTC) From: Mohamed Mediouni To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Mohamed Mediouni , Paolo Bonzini , Phil Dennis-Jordan , Roman Bolshakov , Pierrick Bouvier , Pedro Barbuda , Wei Liu , "Michael S. Tsirkin" , Peter Maydell , Zhao Liu Subject: [PATCH v2 04/38] whpx: i386: disable TbFlushHypercalls for emulated LAPIC Date: Mon, 20 Apr 2026 12:42:14 +0200 Message-ID: <20260420104248.86702-5-mohamed@unpredictable.fr> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260420104248.86702-1-mohamed@unpredictable.fr> References: <20260420104248.86702-1-mohamed@unpredictable.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: vD2UKpINrLvOxGClEngNk6w-aaqxV7Ky X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIwMDEwNCBTYWx0ZWRfX9PRK9R7HixMk oIXN+I2rx004icuPsv1GRzPAcbaHnBpWNkGHaRNinHPEK//VWyvdP4xj+bilgjhDvLlfvN35bc8 3V4QsH7Pv+Yh9jIO6YOjxD2Tw937F2tMwFLegG5BE5NBzAXuFiNcQ+7x8Y4nebD91uIwz/X5adE GrBvFv1ejdO2zCak74mbN4pW7ceLwArio2wEtPMRDymXgxY5oUR6sxROqaEVGFGoTeVf1NOAbWv YFzzmvNtjcO5n43t1ss+sQElZdbEc12qIoDRDm0rjOeJRpVpjJdIj4GIJyVVtepzNFP9eOi9qZt v9UTqETeqKcGPUTHyfCZgLsN9yZXuWLT70TSm64ceVKrI/Kf/+3FrNEM/YjO2g= X-Authority-Info-Out: v=2.4 cv=XaGEDY55 c=1 sm=1 tr=0 ts=69e60339 cx=c_apl:c_pps:t_out a=qkKslKyYc0ctBTeLUVfTFg==:117 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Rm0zj2O9plGGl-KjdfMA:9 X-Proofpoint-ORIG-GUID: vD2UKpINrLvOxGClEngNk6w-aaqxV7Ky X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-20_02,2026-04-17_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 suspectscore=0 adultscore=0 mlxlogscore=777 phishscore=0 bulkscore=0 mlxscore=0 clxscore=1030 lowpriorityscore=0 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2604200104 Received-SPF: pass client-ip=57.103.72.181; envelope-from=mohamed@unpredictable.fr; helo=outbound.ms.icloud.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org AccessHypercallRegs was present twice so clean that up. Remove TbFlushHypercalls (and its extended Gva range sub-feature) from the user-mode LAPIC case as it behaves oddly there. Signed-off-by: Mohamed Mediouni --- target/i386/whpx/whpx-all.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 2d527b90dd..0908dfd134 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2489,10 +2489,7 @@ int whpx_accel_init(AccelState *as, MachineState *ms) synthetic_features.Bank0.AccessPartitionReferenceTsc = 1; synthetic_features.Bank0.AccessHypercallRegs = 1; synthetic_features.Bank0.AccessFrequencyRegs = 1; - synthetic_features.Bank0.EnableExtendedGvaRangesForFlushVirtualAddressList = 1; synthetic_features.Bank0.AccessVpIndex = 1; - synthetic_features.Bank0.AccessHypercallRegs = 1; - synthetic_features.Bank0.TbFlushHypercalls = 1; if (whpx_irqchip_in_kernel()) { synthetic_features.Bank0.AccessSynicRegs = 1; @@ -2500,6 +2497,12 @@ int whpx_accel_init(AccelState *as, MachineState *ms) synthetic_features.Bank0.AccessIntrCtrlRegs = 1; synthetic_features.Bank0.SyntheticClusterIpi = 1; synthetic_features.Bank0.DirectSyntheticTimers = 1; + /* + * These technically work without the Hyper-V LAPIC + * but behave oddly for multi-core VMs. + */ + synthetic_features.Bank0.TbFlushHypercalls = 1; + synthetic_features.Bank0.EnableExtendedGvaRangesForFlushVirtualAddressList = 1; } if (is_modern_os && whpx->hyperv_enlightenments_allowed) { -- 2.50.1 (Apple Git-155)