From: Kees Cook <kees@kernel.org>
To: "Thomas Weißschuh (Schneider Electric)"
<thomas.weissschuh@linutronix.de>
Cc: Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>, Shuah Khan <shuah@kernel.org>,
Sun Jian <sun.jian.kdev@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: harness: Restore order of test functions
Date: Mon, 20 Apr 2026 15:02:28 -0700 [thread overview]
Message-ID: <202604201502.AA9836C@keescook> (raw)
In-Reply-To: <20260420-kselftests-harness-order-v1-1-b3c603782ce8@linutronix.de>
On Mon, Apr 20, 2026 at 10:44:04AM +0200, Thomas Weißschuh (Schneider Electric) wrote:
> The recent addition of explicit constructor orders for fixture tests
> broke the ordering of those relative to non-fixture tests and the
> reverse-constructor-order detection.
>
> Restore the ordering of the test functions relative to each other by
> using the same explicit test order for all test registrations and
> __constructor_order_first().
>
> Rename the constant, as it is not specific to TEST_F() anymore.
>
> Fixes: 6be268151426 ("selftests/harness: order TEST_F and XFAIL_ADD constructors")
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Ah, good catch!
Reviewed-by: Kees Cook <kees@kernel.org>
-Kees
--
Kees Cook
prev parent reply other threads:[~2026-04-20 22:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 8:44 [PATCH] selftests: harness: Restore order of test functions Thomas Weißschuh (Schneider Electric)
2026-04-20 22:02 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202604201502.AA9836C@keescook \
--to=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=shuah@kernel.org \
--cc=sun.jian.kdev@gmail.com \
--cc=thomas.weissschuh@linutronix.de \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.