From: Jonathan Cameron <jic23@kernel.org>
To: Chuang Zhu <git@chuang.cz>
Cc: Rob Herring <robh@kernel.org>, linux-iio@vger.kernel.org
Subject: Re: [PATCH v3] iio: adc: ina2xx: add INA236 support
Date: Mon, 20 Apr 2026 15:28:01 +0100 [thread overview]
Message-ID: <20260420152801.34e6844b@jic23-huawei> (raw)
In-Reply-To: <ef14ecd8-b35d-495c-a4e1-b6ae9d81e7a7@chuang.cz>
On Sun, 12 Apr 2026 23:21:59 +0800
Chuang Zhu <git@chuang.cz> wrote:
> On 4/8/26 23:55, Rob Herring wrote:
> >> @@ -1082,6 +1117,10 @@ static const struct of_device_id ina2xx_of_match[] = {
> >> .compatible = "ti,ina231",
> >> .data = (void *)ina226
> >> },
> >> + {
> >> + .compatible = "ti,ina236",
> >
> > This is not documented. Please add/extend a binding for it.
>
> There is only a devicetree/bindings/hwmon/ti,ina2xx.yaml, but I only
> added support for IIO (no HWMON). Should I extend the existing binding
> regardless?
>
Good question. Given no DT maintainer reply (most aren't in +CC)
I'd go for it and see if you get push back.
J
> Thanks,
> Chuang
>
> > Rob
>
prev parent reply other threads:[~2026-04-20 14:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 18:23 [PATCH v3] iio: adc: ina2xx: add INA236 support Chuang Zhu
2026-03-21 19:45 ` Jonathan Cameron
2026-04-08 15:55 ` Rob Herring
2026-04-12 14:34 ` Jonathan Cameron
2026-04-12 15:21 ` Chuang Zhu
2026-04-20 14:28 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260420152801.34e6844b@jic23-huawei \
--to=jic23@kernel.org \
--cc=git@chuang.cz \
--cc=linux-iio@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.