All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Guilherme Ivo Bozi" <guilherme.bozi@usp.br>,
	"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad4170: use lookup table for gpio mask selection
Date: Mon, 20 Apr 2026 19:01:39 +0100	[thread overview]
Message-ID: <20260420190139.37377770@jic23-huawei> (raw)
In-Reply-To: <adQOnSHRS3baSTLv@ashevche-desk.local>

On Mon, 6 Apr 2026 22:50:53 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Sun, Apr 05, 2026 at 06:37:26PM -0300, Guilherme Ivo Bozi wrote:
> > Both ad4170_gpio_direction_input() and
> > ad4170_gpio_direction_output() duplicate the same switch
> > statement to map a GPIO offset to its corresponding mask.
> > 
> > Replace the switch with a static lookup table, simplifying the code
> > and avoiding duplication. This also makes future extensions easier.
> > 
> > No functional change intended.  
> 
> If this churn is okay by maintainers,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 
Applied.

Thanks,

J


  reply	other threads:[~2026-04-20 18:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-05 21:37 [PATCH] iio: adc: ad4170: use lookup table for gpio mask selection Guilherme Ivo Bozi
2026-04-06 19:50 ` Andy Shevchenko
2026-04-20 18:01   ` Jonathan Cameron [this message]
2026-04-12 13:52 ` Marcelo Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260420190139.37377770@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=guilherme.bozi@usp.br \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt@analog.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.