From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD658F5A8BC for ; Mon, 20 Apr 2026 21:21:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID :References:Mime-Version:In-Reply-To:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tj0RssUNicGJ66KwxjdUfjvyb/L9pBPBmAYnU+4Tock=; b=eyYhAvSpKgTyED zIU0hfzTaiFtuygNQYtudbMGQQ17yG8iNAfhSwzJ7fbaaBX20QjtBxY5irnotdQEhfzj1Gwrj2cN8 +EzGKNSlODJaYP4kWItJoQONDbh0kM2PAdEafr26ElcuOVaq/Yc1BDGLXNLzwCpoeGx8l8XFJ0f8h mqjXY6SU4WF9YYsDMSfrhq5dhqmfYRJc/pYwE7f8ikbHpuClsTpGy4ej5LiLelDUOImpAxn6h2jbk grCS+QnnV5xYg460mGjWA5SwufUk9ElaHzl91cQ7V7DfVAISl6SAcwRlB0teX1uW6EQ7eKC/ciu3u Ugo1JZSs23OoGxFET4Ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wEw3I-00000007gZI-2ADG; Mon, 20 Apr 2026 21:21:08 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wEw2o-00000007fxw-3kof for kvm-riscv@bombadil.infradead.org; Mon, 20 Apr 2026 21:20:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:Cc:To:From:Subject: Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jearMQMOM45vciFPdayTOFGaCCeoL5RElweUFZze4JY=; b=is4g4Zoxs7Onygn6rjQr8dE4wc F+fzjcXK4tcrslS6UmOTNVtlKT6pNYZcI+RQHKAqGIAnQsIBIklk+/v/JJyV3sgCWwlvhp5nhKgE9 jeAotFLX9EkQHW2cSjhxD7lBGfHk6A7gdkGpt9g2604CIWJTHpZbFBJ4/HnlrLbb/zsGA1K1HOqE5 RloGHNB9Cw0jV74mseGMvpTGYmhtUUiyjA5dP7qMHqB+1iFaTnATI5vuZcvSIw1xJ/OrUsrxLXi/r a6CkKD76O07pzwla1RftgPyOzJSkMAvLrP1devMDWpdj6y+0xLfbIqZpJFpNKMe65KWcCz70OoJtT aQ5Ocy4Q==; Received: from mail-pf1-x449.google.com ([2607:f8b0:4864:20::449]) by casper.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wEw2l-000000093NU-2tHg for kvm-riscv@lists.infradead.org; Mon, 20 Apr 2026 21:20:37 +0000 Received: by mail-pf1-x449.google.com with SMTP id d2e1a72fcca58-82f6a5b4f88so4688989b3a.2 for ; Mon, 20 Apr 2026 14:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776720031; x=1777324831; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=jearMQMOM45vciFPdayTOFGaCCeoL5RElweUFZze4JY=; b=M2OlCJ+NzHmPcXPlDLV6kbXECMIxmn9ywNOOnmc8sWCpM8AurlJzYq7NF1CKjeaybZ NFxdwGG0KT5urL/gsiAcw+ig136ymyH2gVn2zG9oQSYjLLeuTpIxu8uQ0njr3knudfGx DS5bAb4H0vXOjAiFJ7wbGHnBFyQWBccZu9oPzCQYN0Pg6aRcYqklzYwWTt22z/FM0bGx 4boC0lIyeyzVk0cCJKQr8Zm5HdKAMG5UWelgl4lqY/lgq0ytwQrXmiWZBRh7sqYWzk0e hOQw+JG8eCZennHT25LVrgm5Rcn5TB/G9SWTjEoc11v4j210OQf3tVclwu/FpuKUObrp ivKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776720031; x=1777324831; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jearMQMOM45vciFPdayTOFGaCCeoL5RElweUFZze4JY=; b=UAQUQEbD4utqz6oxHzEUmLV8R5gpBDIR87Gwwj5ZhWjzVMHwqYOY5JTRIkoFWht9dZ uH9kHfSAJxcCoBJrSQGWLBFa/hWlTKRazTcutbzyqZMoODB617KzqBI3fWJKByUzi/AU 3VVb37WFbaX2kmwUGXtHhXzOz7C/ZTJyXlTpymr73QlF99N2tOfRGP/uWgBWEAjIM6XY jICRlq0PIXHk8UQloLegv9jbVJocP3eMwtgpkufyvltT+MAgtAK3cRq0LZ3n8CYWkBJg TlmCtrECzdFn3Gt3wsr+KLWwvU8iV/zqzNgILPjNS5gXd9t4YB6puLNmnpHmsMlPuXY0 3XQQ== X-Forwarded-Encrypted: i=1; AFNElJ9+8crMgZjfaFLnclkBFg6t/Ck+ITt5hr3MswTu1/rVe92qcqnu8l4rNErTd1FjZfg5oJ5Y7MIRuMI=@lists.infradead.org X-Gm-Message-State: AOJu0YzmIrBSxeicWuueJ5LMiynPaxSP4foyXV3TrFHf/0zbmKP3yucI 4YZMw+16x34mAqRyfRAP51peCJXEGmlk/pWmjxomZRhBQDVmsETK46mpcr1Qjra3vkyMDmq1cb/ iCPe3DA== X-Received: from pfbhx21.prod.google.com ([2002:a05:6a00:8995:b0:82f:8b22:bc77]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:17a1:b0:82c:e83d:a9b0 with SMTP id d2e1a72fcca58-82f8c850e93mr15532322b3a.21.1776720031083; Mon, 20 Apr 2026 14:20:31 -0700 (PDT) Date: Mon, 20 Apr 2026 14:19:58 -0700 In-Reply-To: <20260420212004.3938325-1-seanjc@google.com> Mime-Version: 1.0 References: <20260420212004.3938325-1-seanjc@google.com> X-Mailer: git-send-email 2.54.0.rc1.555.g9c883467ad-goog Message-ID: <20260420212004.3938325-14-seanjc@google.com> Subject: [PATCH v3 13/19] KVM: selftests: Rename vm_vaddr_populate_bitmap() => vm_populate_gva_bitmap() From: Sean Christopherson To: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Sean Christopherson Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260420_222035_766801_5FC836E8 X-CRM114-Status: UNSURE ( 9.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Sean Christopherson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org Now that KVM selftests use gva_t instead of vm_vaddr_t, rename the helper for populating the initial GVA bitmap to drop the defunct terminology and use "vm" for the scope. Opportunistically fixup the declaration of the API, which has been broken since day 1. The flaw went unnoticed because the sole caller is defined after the weak version, i.e. can see the prototype without a previous declaration. No functional change intended. Fixes: e8b9a055fa04 ("KVM: arm64: selftests: Align VA space allocator with TTBR0") Signed-off-by: Sean Christopherson --- tools/testing/selftests/kvm/include/kvm_util.h | 2 +- tools/testing/selftests/kvm/lib/arm64/processor.c | 2 +- tools/testing/selftests/kvm/lib/kvm_util.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/kvm/include/kvm_util.h b/tools/testing/selftests/kvm/include/kvm_util.h index 0239e89320e5..0fbfb2a28767 100644 --- a/tools/testing/selftests/kvm/include/kvm_util.h +++ b/tools/testing/selftests/kvm/include/kvm_util.h @@ -714,7 +714,7 @@ void vm_mem_region_reload(struct kvm_vm *vm, u32 slot); void vm_mem_region_move(struct kvm_vm *vm, u32 slot, u64 new_gpa); void vm_mem_region_delete(struct kvm_vm *vm, u32 slot); struct kvm_vcpu *__vm_vcpu_add(struct kvm_vm *vm, u32 vcpu_id); -void vm_populate_vaddr_bitmap(struct kvm_vm *vm); +void vm_populate_gva_bitmap(struct kvm_vm *vm); gva_t vm_unused_gva_gap(struct kvm_vm *vm, size_t sz, gva_t vaddr_min); gva_t vm_alloc(struct kvm_vm *vm, size_t sz, gva_t vaddr_min); gva_t __vm_alloc(struct kvm_vm *vm, size_t sz, gva_t vaddr_min, diff --git a/tools/testing/selftests/kvm/lib/arm64/processor.c b/tools/testing/selftests/kvm/lib/arm64/processor.c index c4f0e37f2907..384b6c80b1e7 100644 --- a/tools/testing/selftests/kvm/lib/arm64/processor.c +++ b/tools/testing/selftests/kvm/lib/arm64/processor.c @@ -671,7 +671,7 @@ void kvm_selftest_arch_init(void) guest_modes_append_default(); } -void vm_vaddr_populate_bitmap(struct kvm_vm *vm) +void vm_populate_gva_bitmap(struct kvm_vm *vm) { /* * arm64 selftests use only TTBR0_EL1, meaning that the valid VA space diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c index 8c82b40a7448..1a1b41021cc7 100644 --- a/tools/testing/selftests/kvm/lib/kvm_util.c +++ b/tools/testing/selftests/kvm/lib/kvm_util.c @@ -267,7 +267,7 @@ _Static_assert(sizeof(vm_guest_mode_params)/sizeof(struct vm_guest_mode_params) * based on the MSB of the VA. On architectures with this behavior * the VA region spans [0, 2^(va_bits - 1)), [-(2^(va_bits - 1), -1]. */ -__weak void vm_vaddr_populate_bitmap(struct kvm_vm *vm) +__weak void vm_populate_gva_bitmap(struct kvm_vm *vm) { sparsebit_set_num(vm->vpages_valid, 0, (1ULL << (vm->va_bits - 1)) >> vm->page_shift); @@ -385,7 +385,7 @@ struct kvm_vm *____vm_create(struct vm_shape shape) /* Limit to VA-bit canonical virtual addresses. */ vm->vpages_valid = sparsebit_alloc(); - vm_vaddr_populate_bitmap(vm); + vm_populate_gva_bitmap(vm); /* Limit physical addresses to PA-bits. */ vm->max_gfn = vm_compute_max_gfn(vm); -- 2.54.0.rc1.555.g9c883467ad-goog -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 828163D093B for ; Mon, 20 Apr 2026 21:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776720035; cv=none; b=UOEERT0qv24SGvYdCtBTvg3ESJoReyd37HrwRfn/tj4dT+/6NZWV5GC0ezJYbl0NaaOsAZ7VHMI++8t2OkyQ7agXj2Rr2GDFDtv0uajznkq9S5XPDB5pyNXW1DTv8JnpHFG0N4OJu95HbF86e4kdyUTmCjg2slEQi8+Ro6tmcCo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776720035; c=relaxed/simple; bh=yEgveHaBMKIIsW+doZiDb1nQpM20TwqcCTmsBmJmV/o=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=kHej5CTSYuriD/Fzlz9gJXPxJridhFK15OrL4V3WL9INdZALDwXqddHgxV3Vdt1YsP1o53iNV/HLLRynAERIqbNHRWHDXT2Ohkc1XBsPgG4UD49aDN8avDELA5xGBJAiAYtemfXUfwGO3NYAaonqpbZkB6KwYABgcQ+NWQ33q+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=cHDdD0Ov; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cHDdD0Ov" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-82f803658d5so4245058b3a.1 for ; Mon, 20 Apr 2026 14:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776720031; x=1777324831; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=jearMQMOM45vciFPdayTOFGaCCeoL5RElweUFZze4JY=; b=cHDdD0Ov3C3QPr5TnrTZOlFoyhiwsS2UvXzSxdLFtXhgDBmDhRurLvtkfxli+2PeJI mQh+jkRzAzKWWL762ez6G7vbtJI0B/E9D/44Xhh6d/Lm9lB35WZ+wMPa5668RSEZvE+D LwexPUKFyu0EwErDJwZx6YdAnFwNC5Mv59i2d8MV2WKEKo8iL0V3ppWu0uKVZSbjUKro 6CoCnvloh7nbs6cNMRP5xI4bmoaCwmPFxIBXVa7l3QR+1nmNhSkZ5CX2F27YyxHUqx1D +vMfX1FAaNyOiM7jDm0oytuL3dTRXy1S0O9jlPFaiulS+ivH/FJyWU3I8qKtWOFkIonY skGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776720031; x=1777324831; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jearMQMOM45vciFPdayTOFGaCCeoL5RElweUFZze4JY=; b=fheB5cU7K0JIXgdSQzreuz++1Ee4Mv4n8/NGiPLvO2MRNTpMLOwQ4L+sRxg2CtNRFG tspQ7wgKr4PIqOf5SubVBrOZcqJ2m554pXUfthCvtR2NsqtCG9d8T8C4A2pMF/v2WpWA kohdEtr8cX/k53XOGOfUqbuLEcHhlehc1nWrT8R3KlYB1/oO+jtokGv2KUjswp1em45s ILuqhMOJ+Y3bKiiHrj7gbZsiHTre7/7lTx5X7CI6HWM+WasFAI2ukqHeGmdQglUzNsbq Ca3a9QmtYjfmBNKTWwRXLmkbWaKQKvM8sigt9wnpVwkr+Fct8recGZr+JB2YBBReOj1X Sg0w== X-Gm-Message-State: AOJu0Ywb6fhd2usU0bXa60UwFZ+LdrR8w4/eVj9qcHd+u2EWaDgrrJns 8aIZ5dilZ4EtgK1/tUhRO8usuVANw5Y6VrJTfXiWylhQD03QqTG3Oa8uXlR0BglRWYJpDTZp/nl DyKW8wA== X-Received: from pfbhx21.prod.google.com ([2002:a05:6a00:8995:b0:82f:8b22:bc77]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:17a1:b0:82c:e83d:a9b0 with SMTP id d2e1a72fcca58-82f8c850e93mr15532322b3a.21.1776720031083; Mon, 20 Apr 2026 14:20:31 -0700 (PDT) Reply-To: Sean Christopherson Date: Mon, 20 Apr 2026 14:19:58 -0700 In-Reply-To: <20260420212004.3938325-1-seanjc@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260420212004.3938325-1-seanjc@google.com> X-Mailer: git-send-email 2.54.0.rc1.555.g9c883467ad-goog Message-ID: <20260420212004.3938325-14-seanjc@google.com> Subject: [PATCH v3 13/19] KVM: selftests: Rename vm_vaddr_populate_bitmap() => vm_populate_gva_bitmap() From: Sean Christopherson To: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Sean Christopherson Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack Content-Type: text/plain; charset="UTF-8" Now that KVM selftests use gva_t instead of vm_vaddr_t, rename the helper for populating the initial GVA bitmap to drop the defunct terminology and use "vm" for the scope. Opportunistically fixup the declaration of the API, which has been broken since day 1. The flaw went unnoticed because the sole caller is defined after the weak version, i.e. can see the prototype without a previous declaration. No functional change intended. Fixes: e8b9a055fa04 ("KVM: arm64: selftests: Align VA space allocator with TTBR0") Signed-off-by: Sean Christopherson --- tools/testing/selftests/kvm/include/kvm_util.h | 2 +- tools/testing/selftests/kvm/lib/arm64/processor.c | 2 +- tools/testing/selftests/kvm/lib/kvm_util.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/kvm/include/kvm_util.h b/tools/testing/selftests/kvm/include/kvm_util.h index 0239e89320e5..0fbfb2a28767 100644 --- a/tools/testing/selftests/kvm/include/kvm_util.h +++ b/tools/testing/selftests/kvm/include/kvm_util.h @@ -714,7 +714,7 @@ void vm_mem_region_reload(struct kvm_vm *vm, u32 slot); void vm_mem_region_move(struct kvm_vm *vm, u32 slot, u64 new_gpa); void vm_mem_region_delete(struct kvm_vm *vm, u32 slot); struct kvm_vcpu *__vm_vcpu_add(struct kvm_vm *vm, u32 vcpu_id); -void vm_populate_vaddr_bitmap(struct kvm_vm *vm); +void vm_populate_gva_bitmap(struct kvm_vm *vm); gva_t vm_unused_gva_gap(struct kvm_vm *vm, size_t sz, gva_t vaddr_min); gva_t vm_alloc(struct kvm_vm *vm, size_t sz, gva_t vaddr_min); gva_t __vm_alloc(struct kvm_vm *vm, size_t sz, gva_t vaddr_min, diff --git a/tools/testing/selftests/kvm/lib/arm64/processor.c b/tools/testing/selftests/kvm/lib/arm64/processor.c index c4f0e37f2907..384b6c80b1e7 100644 --- a/tools/testing/selftests/kvm/lib/arm64/processor.c +++ b/tools/testing/selftests/kvm/lib/arm64/processor.c @@ -671,7 +671,7 @@ void kvm_selftest_arch_init(void) guest_modes_append_default(); } -void vm_vaddr_populate_bitmap(struct kvm_vm *vm) +void vm_populate_gva_bitmap(struct kvm_vm *vm) { /* * arm64 selftests use only TTBR0_EL1, meaning that the valid VA space diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c index 8c82b40a7448..1a1b41021cc7 100644 --- a/tools/testing/selftests/kvm/lib/kvm_util.c +++ b/tools/testing/selftests/kvm/lib/kvm_util.c @@ -267,7 +267,7 @@ _Static_assert(sizeof(vm_guest_mode_params)/sizeof(struct vm_guest_mode_params) * based on the MSB of the VA. On architectures with this behavior * the VA region spans [0, 2^(va_bits - 1)), [-(2^(va_bits - 1), -1]. */ -__weak void vm_vaddr_populate_bitmap(struct kvm_vm *vm) +__weak void vm_populate_gva_bitmap(struct kvm_vm *vm) { sparsebit_set_num(vm->vpages_valid, 0, (1ULL << (vm->va_bits - 1)) >> vm->page_shift); @@ -385,7 +385,7 @@ struct kvm_vm *____vm_create(struct vm_shape shape) /* Limit to VA-bit canonical virtual addresses. */ vm->vpages_valid = sparsebit_alloc(); - vm_vaddr_populate_bitmap(vm); + vm_populate_gva_bitmap(vm); /* Limit physical addresses to PA-bits. */ vm->max_gfn = vm_compute_max_gfn(vm); -- 2.54.0.rc1.555.g9c883467ad-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2648BF5A8C5 for ; Mon, 20 Apr 2026 21:21:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID :References:Mime-Version:In-Reply-To:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NXQ5bo6wXnAffUGpjw2DJ89XGCL9pQ57SiSSWI/7o+Q=; b=be+rFhS0g2hgod eLO3ABJ8dFJc0eh7CwFlFF+tZ9/nUjgNPls3X4r1Bs65KNSmIqmypqsRPIxQgtuZy9PaanI7zxkeN fLOhNDQN/CHaY+nC5x9oUBaoDKKvjMAX8vMkav2G1MyerUi+e8x4nvdw9RxDrSyZiawUsTf4ra+Oa 1Kkn2vYmp9MtHBzGjqpInGKPZ/GfMi8JLXXfg2FINWQ+iDCmg8GqamYvQrrKq1J0eVgBP2J2N3IiZ ayYB80sof5Ve64jSvGyI36Riff6Ez7g8T89MuVVCBDgb6M0Ug+aELY0f1wOIMU+M4XXaATOHCFSFt ldQENr17hZIiDpeGTBVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wEw3R-00000007gls-1rYR; Mon, 20 Apr 2026 21:21:17 +0000 Received: from mail-pf1-x44a.google.com ([2607:f8b0:4864:20::44a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wEw2j-00000007fqm-2D6y for linux-riscv@lists.infradead.org; Mon, 20 Apr 2026 21:20:44 +0000 Received: by mail-pf1-x44a.google.com with SMTP id d2e1a72fcca58-82f803658d5so4245057b3a.1 for ; Mon, 20 Apr 2026 14:20:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776720031; x=1777324831; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=jearMQMOM45vciFPdayTOFGaCCeoL5RElweUFZze4JY=; b=M2OlCJ+NzHmPcXPlDLV6kbXECMIxmn9ywNOOnmc8sWCpM8AurlJzYq7NF1CKjeaybZ NFxdwGG0KT5urL/gsiAcw+ig136ymyH2gVn2zG9oQSYjLLeuTpIxu8uQ0njr3knudfGx DS5bAb4H0vXOjAiFJ7wbGHnBFyQWBccZu9oPzCQYN0Pg6aRcYqklzYwWTt22z/FM0bGx 4boC0lIyeyzVk0cCJKQr8Zm5HdKAMG5UWelgl4lqY/lgq0ytwQrXmiWZBRh7sqYWzk0e hOQw+JG8eCZennHT25LVrgm5Rcn5TB/G9SWTjEoc11v4j210OQf3tVclwu/FpuKUObrp ivKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776720031; x=1777324831; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jearMQMOM45vciFPdayTOFGaCCeoL5RElweUFZze4JY=; b=EZDOAnswJ0vkLjxSYQDeNPMLo2Y7UKgTScU3eP8oXeL73BJ569juvP2eW91GvAuFXX fi02Ikty9Bgk/x22VQtM8SLrfUdbxI1g42j8MbHkXcAICWQWEs7uAFsjyRvEIXB7JGd8 ud49qwr8RazGemIvQLUVHMmowk2a/No0MDOqFWBXlAa2KlQeH4ZY2osgf8naiHgV1FKR ULoqSYK/LZJcuu60ZAaK/+mJ9erl4zRu0ZuO8HDsbx/fLXUF9WRXTaECllidbyS0qXKb f/bWKspb5js6Z8/OvsfNt2n2itB8EUr+2oqGy/Fz9+XVblf8VKBO/+TKtwXgmJia40jt qwmw== X-Forwarded-Encrypted: i=1; AFNElJ9L2ZDnyTrFzM20Eol1EEF5AerRQDu+kJZhfcUE+jHjo6AAxsMyb3ffhwGHmHLyPVqD1RFc2HaoAkuGmA==@lists.infradead.org X-Gm-Message-State: AOJu0YxCJt1rGktT9V1B8eVfqsEA0a0c1M3wHRSJntLf2odSTv9lkSm+ 0VEpX6D/I+KcbpKPojnKauvDiRd4UKYpPkSGgBBLL+vAHLuV2zjibnVtKlYn6rrmLNth9y9ZFyK 3Xt80Nw== X-Received: from pfbhx21.prod.google.com ([2002:a05:6a00:8995:b0:82f:8b22:bc77]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:17a1:b0:82c:e83d:a9b0 with SMTP id d2e1a72fcca58-82f8c850e93mr15532322b3a.21.1776720031083; Mon, 20 Apr 2026 14:20:31 -0700 (PDT) Date: Mon, 20 Apr 2026 14:19:58 -0700 In-Reply-To: <20260420212004.3938325-1-seanjc@google.com> Mime-Version: 1.0 References: <20260420212004.3938325-1-seanjc@google.com> X-Mailer: git-send-email 2.54.0.rc1.555.g9c883467ad-goog Message-ID: <20260420212004.3938325-14-seanjc@google.com> Subject: [PATCH v3 13/19] KVM: selftests: Rename vm_vaddr_populate_bitmap() => vm_populate_gva_bitmap() From: Sean Christopherson To: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Sean Christopherson Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260420_142033_675182_48461103 X-CRM114-Status: GOOD ( 11.75 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Sean Christopherson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Now that KVM selftests use gva_t instead of vm_vaddr_t, rename the helper for populating the initial GVA bitmap to drop the defunct terminology and use "vm" for the scope. Opportunistically fixup the declaration of the API, which has been broken since day 1. The flaw went unnoticed because the sole caller is defined after the weak version, i.e. can see the prototype without a previous declaration. No functional change intended. Fixes: e8b9a055fa04 ("KVM: arm64: selftests: Align VA space allocator with TTBR0") Signed-off-by: Sean Christopherson --- tools/testing/selftests/kvm/include/kvm_util.h | 2 +- tools/testing/selftests/kvm/lib/arm64/processor.c | 2 +- tools/testing/selftests/kvm/lib/kvm_util.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/kvm/include/kvm_util.h b/tools/testing/selftests/kvm/include/kvm_util.h index 0239e89320e5..0fbfb2a28767 100644 --- a/tools/testing/selftests/kvm/include/kvm_util.h +++ b/tools/testing/selftests/kvm/include/kvm_util.h @@ -714,7 +714,7 @@ void vm_mem_region_reload(struct kvm_vm *vm, u32 slot); void vm_mem_region_move(struct kvm_vm *vm, u32 slot, u64 new_gpa); void vm_mem_region_delete(struct kvm_vm *vm, u32 slot); struct kvm_vcpu *__vm_vcpu_add(struct kvm_vm *vm, u32 vcpu_id); -void vm_populate_vaddr_bitmap(struct kvm_vm *vm); +void vm_populate_gva_bitmap(struct kvm_vm *vm); gva_t vm_unused_gva_gap(struct kvm_vm *vm, size_t sz, gva_t vaddr_min); gva_t vm_alloc(struct kvm_vm *vm, size_t sz, gva_t vaddr_min); gva_t __vm_alloc(struct kvm_vm *vm, size_t sz, gva_t vaddr_min, diff --git a/tools/testing/selftests/kvm/lib/arm64/processor.c b/tools/testing/selftests/kvm/lib/arm64/processor.c index c4f0e37f2907..384b6c80b1e7 100644 --- a/tools/testing/selftests/kvm/lib/arm64/processor.c +++ b/tools/testing/selftests/kvm/lib/arm64/processor.c @@ -671,7 +671,7 @@ void kvm_selftest_arch_init(void) guest_modes_append_default(); } -void vm_vaddr_populate_bitmap(struct kvm_vm *vm) +void vm_populate_gva_bitmap(struct kvm_vm *vm) { /* * arm64 selftests use only TTBR0_EL1, meaning that the valid VA space diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c index 8c82b40a7448..1a1b41021cc7 100644 --- a/tools/testing/selftests/kvm/lib/kvm_util.c +++ b/tools/testing/selftests/kvm/lib/kvm_util.c @@ -267,7 +267,7 @@ _Static_assert(sizeof(vm_guest_mode_params)/sizeof(struct vm_guest_mode_params) * based on the MSB of the VA. On architectures with this behavior * the VA region spans [0, 2^(va_bits - 1)), [-(2^(va_bits - 1), -1]. */ -__weak void vm_vaddr_populate_bitmap(struct kvm_vm *vm) +__weak void vm_populate_gva_bitmap(struct kvm_vm *vm) { sparsebit_set_num(vm->vpages_valid, 0, (1ULL << (vm->va_bits - 1)) >> vm->page_shift); @@ -385,7 +385,7 @@ struct kvm_vm *____vm_create(struct vm_shape shape) /* Limit to VA-bit canonical virtual addresses. */ vm->vpages_valid = sparsebit_alloc(); - vm_vaddr_populate_bitmap(vm); + vm_populate_gva_bitmap(vm); /* Limit physical addresses to PA-bits. */ vm->max_gfn = vm_compute_max_gfn(vm); -- 2.54.0.rc1.555.g9c883467ad-goog _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv