From: Johan Hovold <johan@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Vladimir Moravcevic <vmoravcevic@axiado.com>,
Tzu-Hao Wei <twei@axiado.com>, Swark Yang <syang@axiado.com>,
Prasad Bolisetty <pbolisetty@axiado.com>,
Harshit Shah <hshah@axiado.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>
Subject: [PATCH 3/3] spi: axiado: clean up probe return value
Date: Tue, 21 Apr 2026 16:39:25 +0200 [thread overview]
Message-ID: <20260421143925.1551781-4-johan@kernel.org> (raw)
In-Reply-To: <20260421143925.1551781-1-johan@kernel.org>
Drop the redundant initialisation and return explicit zero on successful
probe to make the code more readable.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/spi/spi-axiado.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-axiado.c b/drivers/spi/spi-axiado.c
index a347774ae824..9057a0a8df4a 100644
--- a/drivers/spi/spi-axiado.c
+++ b/drivers/spi/spi-axiado.c
@@ -751,9 +751,9 @@ static const struct spi_controller_mem_ops ax_spi_mem_ops = {
*/
static int ax_spi_probe(struct platform_device *pdev)
{
- int ret = 0, irq;
struct spi_controller *ctlr;
struct ax_spi *xspi;
+ int ret, irq;
u32 num_cs;
ctlr = devm_spi_alloc_host(&pdev->dev, sizeof(*xspi));
@@ -852,7 +852,7 @@ static int ax_spi_probe(struct platform_device *pdev)
pm_runtime_put_autosuspend(&pdev->dev);
- return ret;
+ return 0;
err_disable_rpm:
pm_runtime_disable(&pdev->dev);
--
2.52.0
next prev parent reply other threads:[~2026-04-21 14:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 14:39 [PATCH 0/3] spi: axiado: spi: axiado: fix runtime pm imbalance on probe failure Johan Hovold
2026-04-21 14:39 ` [PATCH 1/3] " Johan Hovold
2026-04-21 14:39 ` [PATCH 2/3] spi: axiado: rename probe error labels Johan Hovold
2026-04-21 14:39 ` Johan Hovold [this message]
2026-04-22 14:06 ` [PATCH 0/3] spi: axiado: spi: axiado: fix runtime pm imbalance on probe failure Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421143925.1551781-4-johan@kernel.org \
--to=johan@kernel.org \
--cc=broonie@kernel.org \
--cc=hshah@axiado.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=pbolisetty@axiado.com \
--cc=syang@axiado.com \
--cc=twei@axiado.com \
--cc=vmoravcevic@axiado.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.