Re: [PATCH v3 03/11] drivers: allow clk_stub and spmi in SPL

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 2647 bytes --]

On Tue, Apr 21, 2026 at 11:05:58PM +0200, Michael Srba wrote:
> Hi,
> 
> On 4/21/26 22:46, Tom Rini wrote:
> > On Tue, Apr 21, 2026 at 09:43:46PM +0200, michael.srba@seznam.cz wrote:
> > 
> > > From: Michael Srba <Michael.Srba@seznam.cz>
> > > 
> > > Only Makefile and Kconfig changes necessary.
> > > 
> > > Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
> > > ---
> > >   drivers/Makefile      |  2 +-
> > >   drivers/clk/Kconfig   |  7 +++++++
> > >   drivers/spmi/Kconfig  | 13 +++++++++++++
> > >   drivers/spmi/Makefile |  4 ++--
> > >   4 files changed, 23 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/Makefile b/drivers/Makefile
> > > index 43d0ba33281..477718ce89a 100644
> > > --- a/drivers/Makefile
> > > +++ b/drivers/Makefile
> > > @@ -35,6 +35,7 @@ obj-$(CONFIG_$(PHASE_)RAM) += ram/
> > >   obj-$(CONFIG_$(PHASE_)RTC) += rtc/
> > >   obj-$(CONFIG_$(PHASE_)SERIAL) += serial/
> > >   obj-$(CONFIG_$(PHASE_)SPI) += spi/
> > > +obj-$(CONFIG_$(PHASE_)SPMI) += spmi/
> > >   obj-$(CONFIG_$(PHASE_)TIMER) += timer/
> > >   obj-$(CONFIG_$(PHASE_)VIRTIO) += virtio/
> > >   obj-$(CONFIG_$(PHASE_)DM_MAILBOX) += mailbox/
> > > @@ -106,7 +107,6 @@ obj-$(CONFIG_DM_REBOOT_MODE) += reboot-mode/
> > >   obj-y += rtc/
> > >   obj-y += scsi/
> > >   obj-y += sound/
> > > -obj-y += spmi/
> > >   obj-y += watchdog/
> > >   obj-$(CONFIG_QE) += qe/
> > >   obj-$(CONFIG_U_QE) += qe/
> > Code-wise this is fine. But this reminds me, did you run this whole
> > series through CI? Thanks.
> I tried, but on gitlab.org it just didn't work at all, and locally it only ran partially
> before running out of disk space. I tried making an account
> on https://source.denx.de but the anti-spam measure is blocking me
> and I'm waiting to see if that gets resolved (since it's not clear to me if
> the unblocking is supposed to be automatic or not, and if it's manual
> then just waiting is probably all I need to do) (fwiw not sure if that
> instance allows random users to run the CI, the docs don't really
> say *where* I'm supposed to run it, but I figured it was worth a try)

The thing with source.denx.de is that then you also need (manually) a
contributor tree, for CI (and user accounts are more for bug filing). We
have how to run CI via Azure documented here:
https://docs.u-boot.org/en/latest/develop/ci_testing.html

And my concern is changing "always traverse this directory" to "traverse
once CONFIG_SPMI is set" shouldn't cause a problem. But sometimes
there's platforms with unexpected (and invalid needing to be fixed)
configurations out there.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]