From: Greg KH <gregkh@linuxfoundation.org>
To: Danilo Krummrich <dakr@kernel.org>
Cc: rafael@kernel.org, driver-core@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: move dev_has_sync_state() to drivers/base/base.h
Date: Tue, 21 Apr 2026 08:30:46 +0200 [thread overview]
Message-ID: <2026042136-endeared-wharf-53be@gregkh> (raw)
In-Reply-To: <20260420234153.2898532-1-dakr@kernel.org>
On Tue, Apr 21, 2026 at 01:40:44AM +0200, Danilo Krummrich wrote:
> All callers of dev_has_sync_state() are in drivers/base/ and any attempt
> to use it outside of driver-core should require good justification, so
> there is no need to have it defined in include/linux/device.h.
>
> Thus, move it to drivers/base/base.h.
>
> Suggested-by: Rafael J. Wysocki (Intel) <rafael@kernel.org>
> Link: https://lore.kernel.org/driver-core/CAJZ5v0jkm9K9=-U_51FMsyxN2msdouRnz4sEjmxG0Btd6Hmw0w@mail.gmail.com/
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
> ---
> Goes on top of [1].
>
> [1] https://lore.kernel.org/driver-core/20260418162221.1121873-1-dakr@kernel.org/
> ---
> drivers/base/base.h | 14 ++++++++++++++
> include/linux/device.h | 14 --------------
> 2 files changed, 14 insertions(+), 14 deletions(-)
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2026-04-21 6:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 23:40 [PATCH] driver core: move dev_has_sync_state() to drivers/base/base.h Danilo Krummrich
2026-04-21 6:30 ` Greg KH [this message]
2026-04-21 13:15 ` Rafael J. Wysocki
2026-04-28 22:41 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026042136-endeared-wharf-53be@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.