All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gang Yan <gang.yan@linux.dev>
To: mptcp@lists.linux.dev
Cc: Gang Yan <yangang@kylinos.cn>
Subject: [PATCH mptcp-net 0/2] mptcp: replace lock_sock_fast with sleepable lock
Date: Wed, 22 Apr 2026 17:19:20 +0800	[thread overview]
Message-ID: <20260422091927.77770-1-gang.yan@linux.dev> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 1404 bytes --]

From: Gang Yan <yangang@kylinos.cn>

Hi Matt,

I make some progress about the issue sashiko mentioned in:
https://sashiko.dev/#/patchset/20260420093343.16443-1-gang.yan@linux.dev

The problem does exist,though the trigger conditions seem quite strict.

asdasda shjaksdjh askjd hjklajsdhfj klasjd aklshd kljasldkj akjlsd klklk

I’ve checked how TCP and core socket handle similar sockopt operations,
and found they almost always use sockopt_lock_sock() in 
setsockopt/getsockopt paths — a variant of lock_sock() that also
considers BPF cases.

I think we can align MPTCP with a similar approach to fix this properly.
This will come as a two-patch series, split for easier review and
backporting to stable branches:

    - 0001: The first patch replaces lock_sock_fast() with lock_sock()
      to fix the potential sleeping issue in timestamp and timestamping
      sockopt handlers.

    - 0002: The second patch converts all lock operations in MPTCP
      setsockopt / getsockopt to use sockopt_lock_sock(), preventing
      similar issues from being accidentally introduced in the future.
      And I think it should use 'mptcp-next' tag.

Gang Yan (2):
  mptcp: fix scheduling with atomic in timestamp sockopt
  mptcp: use sockopt_lock(release)_sock in sockopt

 net/mptcp/sockopt.c | 121 ++++++++++++++++++++++----------------------
 1 file changed, 60 insertions(+), 61 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-04-22  9:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22  9:19 Gang Yan [this message]
2026-04-22  9:19 ` [PATCH mptcp-net 1/2] mptcp: fix scheduling with atomic in timestamp sockopt Gang Yan
2026-04-27 14:49   ` Matthieu Baerts
2026-04-22  9:19 ` [PATCH mptcp-next 2/2] mptcp: use sockopt_lock(release)_sock in sockopt Gang Yan
2026-04-27 14:47   ` Matthieu Baerts
2026-04-28  3:09     ` gang.yan
2026-04-23 16:45 ` [PATCH mptcp-net 0/2] mptcp: replace lock_sock_fast with sleepable lock MPTCP CI
2026-04-27 15:04 ` Matthieu Baerts
2026-04-28  2:56   ` gang.yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260422091927.77770-1-gang.yan@linux.dev \
    --to=gang.yan@linux.dev \
    --cc=mptcp@lists.linux.dev \
    --cc=yangang@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.