All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borys Turko <turkoborys@gmail.com>
To: Ike Panhc <ikepanhc@gmail.com>, Hans de Goede <hansg@kernel.org>
Cc: "Mark Pearson" <mpearson-lenovo@squebb.ca>,
	"Derek J . Clark" <derekjohn.clark@gmail.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Borys Turko" <turkoborys@gmail.com>
Subject: [PATCH] platform/x86: ideapad-laptop: remap "Star with S" key to KEY_DASHBOARD
Date: Wed, 22 Apr 2026 12:42:27 +0200	[thread overview]
Message-ID: <20260422104227.19969-1-turkoborys@gmail.com> (raw)

The customizable Lenovo hotkey ("Star with S") on the Lenovo 82EY is
currently mapped to KEY_FAVORITES. However, KEY_FAVORITES is primarily
handled as a browser-specific action (Add to Favorites) and is not
consistently recognized as a system-wide hotkey by modern desktop
environments.

Testing on the Cinnamon desktop environment shows that KEY_FAVORITES
is not captured for system mapping, and it fails to trigger any action
in modern web browsers.

Remapping this key to KEY_DASHBOARD allows it to be treated as a
system-level event. This change enables users to map the key to
system functions (such as a dashboard or launcher) through their
desktop environment's keyboard settings.

Tested on Lenovo 82EY with evtest and Cinnamon DE.

Signed-off-by: Borys Turko <turkoborys@gmail.com>
---
 drivers/platform/x86/lenovo/ideapad-laptop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/lenovo/ideapad-laptop.c b/drivers/platform/x86/lenovo/ideapad-laptop.c
index 4fbc904f1..3a5b5a478 100644
--- a/drivers/platform/x86/lenovo/ideapad-laptop.c
+++ b/drivers/platform/x86/lenovo/ideapad-laptop.c
@@ -1333,7 +1333,7 @@ static const struct key_entry ideapad_keymap[] = {
 	/* Esc (handled by the firmware) */
 	{ KE_IGNORE,	0x03 | IDEAPAD_WMI_KEY },
 	/* Customizable Lenovo Hotkey ("star" with 'S' inside) */
-	{ KE_KEY,	0x01 | IDEAPAD_WMI_KEY, { KEY_FAVORITES } },
+	{ KE_KEY,	0x01 | IDEAPAD_WMI_KEY, { KEY_DASHBOARD } },
 	{ KE_KEY,	0x04 | IDEAPAD_WMI_KEY, { KEY_SELECTIVE_SCREENSHOT } },
 	/* Lenovo Support */
 	{ KE_KEY,	0x07 | IDEAPAD_WMI_KEY, { KEY_HELP } },
-- 
2.54.0


             reply	other threads:[~2026-04-22 10:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 10:42 Borys Turko [this message]
2026-04-23  1:35 ` [PATCH] platform/x86: ideapad-laptop: remap "Star with S" key to KEY_DASHBOARD Mark Pearson
2026-04-23  7:59   ` Borys
2026-05-15 17:38     ` Borys
2026-05-15 17:43       ` Mark Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260422104227.19969-1-turkoborys@gmail.com \
    --to=turkoborys@gmail.com \
    --cc=derekjohn.clark@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ikepanhc@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.