All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Laight <david.laight.linux@gmail.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Marco Elver <elver@google.com>,
	kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>, Miguel Ojeda <ojeda@kernel.org>,
	Dmitry Vyukov <dvyukov@google.com>,
	Nathan Chancellor <nathan@kernel.org>,
	llvm@lists.linux.dev
Subject: Re: [PATCH 1/2] Compiler Attributes: Add __access macro
Date: Wed, 22 Apr 2026 14:02:29 +0100	[thread overview]
Message-ID: <20260422140229.5a6f23f2@pumpkin> (raw)
In-Reply-To: <CANiq72=x5Ye+Cq6FNPTaLNyFJ+OMYQE45hLKibTyrgXfkeBn7g@mail.gmail.com>

On Wed, 22 Apr 2026 12:25:32 +0200
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:

> On Wed, Apr 22, 2026 at 12:01 PM David Laight
> <david.laight.linux@gmail.com> wrote:
> >
> > Putting the actual syntax in the comment would help, eg as:
> >         __access__(read_only|read_write|write_only|none, param_number[, size])  
> 
> I guess you mean as a quick reminder for those that already know about
> the attribute?
> 
> That sounds OK for an attribute like this, though generally speaking I
> would avoid duplicating the compiler docs. (Hopefully people will
> still read the actual docs... :)

It might save someone who is just 'wondering what it is about' from having
to read the gcc docs - particularly if reading the file where you don't have
a browser handy, or in an editor that doesn't support following links.

I also had to read a lot of the 'actual doc' to get a hint of what it
all meant.

> By the way, that could be `__access`, i.e. documenting our side, i.e. the macro.

True, and ', size' should be ', count'.

	David

> 
> Cheers,
> Miguel


      reply	other threads:[~2026-04-22 13:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21 19:03 [PATCH 1/2] Compiler Attributes: Add __access macro Marco Elver
2026-04-21 19:03 ` [PATCH 2/2] kcsan: Silence -Wmaybe-uninitialized when calling __kcsan_check_access() Marco Elver
2026-04-21 19:15 ` [PATCH 1/2] Compiler Attributes: Add __access macro Miguel Ojeda
2026-04-21 19:20   ` Marco Elver
2026-04-21 19:30     ` Arnd Bergmann
2026-04-21 19:35       ` Marco Elver
2026-04-22 10:25       ` Miguel Ojeda
2026-04-22 10:30         ` Miguel Ojeda
2026-04-22 13:22         ` David Laight
2026-04-22  5:50 ` Nathan Chancellor
2026-04-22 10:01 ` David Laight
2026-04-22 10:20   ` Marco Elver
2026-04-22 13:06     ` Marco Elver
2026-04-22 10:25   ` Miguel Ojeda
2026-04-22 13:02     ` David Laight [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260422140229.5a6f23f2@pumpkin \
    --to=david.laight.linux@gmail.com \
    --cc=arnd@arndb.de \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=nathan@kernel.org \
    --cc=ojeda@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.