All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Matt Roper <matthew.d.roper@intel.com>
Subject: [PATCH 03/10] drm/xe: Stop programming BLIT_CCTL on Xe2 and later platforms
Date: Thu, 23 Apr 2026 15:48:50 -0700	[thread overview]
Message-ID: <20260423-engine-setup-v1-3-baa94014e3e5@intel.com> (raw)
In-Reply-To: <20260423-engine-setup-v1-0-baa94014e3e5@intel.com>

Xe1 platforms used the BLIT_CCTL register to specify the MOCS value that
would be used for BCS engine instructions that did not have a way of
specifying a MOCS index directly.  From Xe2 onward, all BCS instructions
now have explicit instruction fields for specifying a MOCS index and the
BLIT_CCTL register is now a dummy register with no valid fields.
Although continuing to write to it today has no effect, the register
could repurposed in future platforms, so restrict the BLIT_CCTL RTP
entry to only apply to Xe1 platforms.

Bspec: 60280
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/xe/xe_hw_engine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c
index 48cb52a1ec2d..62a47d7e3f02 100644
--- a/drivers/gpu/drm/xe/xe_hw_engine.c
+++ b/drivers/gpu/drm/xe/xe_hw_engine.c
@@ -384,7 +384,7 @@ xe_hw_engine_setup_default_lrc_state(struct xe_hw_engine *hwe)
 		 * BLIT_CCTL registers are needed to be programmed to un-cached.
 		 */
 		{ XE_RTP_NAME("BLIT_CCTL_default_MOCS"),
-		  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, XE_RTP_END_VERSION_UNDEFINED),
+		  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, 1274),
 			       ENGINE_CLASS(COPY)),
 		  XE_RTP_ACTIONS(FIELD_SET(BLIT_CCTL(0),
 				 BLIT_CCTL_DST_MOCS_MASK |

-- 
2.53.0


  parent reply	other threads:[~2026-04-23 22:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23 22:48 [PATCH 00/10] Engine initialization cleanup Matt Roper
2026-04-23 22:48 ` [PATCH 01/10] drm/xe: Move CCS enablement to engine setup RTP Matt Roper
2026-04-24 19:21   ` Matt Roper
2026-04-23 22:48 ` [PATCH 02/10] drm/xe/rtp: Add "always true" match function Matt Roper
2026-04-24 17:17   ` Lin, Shuicheng
2026-04-23 22:48 ` Matt Roper [this message]
2026-04-23 22:48 ` [PATCH 04/10] drm/xe: Move HWSTAM programming to RTP Matt Roper
2026-04-24 18:15   ` Lin, Shuicheng
2026-04-23 22:48 ` [PATCH 05/10] drm/xe: Fix name and definition of GFX_MODE register Matt Roper
2026-04-23 22:48 ` [PATCH 06/10] drm/xe: Const-ify parameters to xe_device_has_* functions Matt Roper
2026-04-24  7:27   ` Michal Wajdeczko
2026-04-23 22:48 ` [PATCH 07/10] drm/xe: Move GFX_MODE programming to RTP Matt Roper
2026-04-24 17:24   ` Lin, Shuicheng
2026-04-23 22:48 ` [PATCH 08/10] drm/xe: Drop unnecessary STOP_RING clearing Matt Roper
2026-04-23 22:48 ` [PATCH 09/10] drm/xe: Drop xe_hw_engine_mmio_write32() Matt Roper
2026-04-24 17:06   ` Lin, Shuicheng
2026-04-23 22:48 ` [PATCH 10/10] drm/xe: Mark BCS engines as belonging to the GT forcewake domain Matt Roper
2026-04-24 16:46   ` Lin, Shuicheng
2026-04-23 22:56 ` ✓ CI.KUnit: success for Engine initialization cleanup Patchwork
2026-04-23 23:44 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-04-24  5:34 ` ✓ Xe.CI.FULL: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260423-engine-setup-v1-3-baa94014e3e5@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.