Re: [PATCH] dt-bindings: mfd: hisilicon,hi655x-pmic: Convert to DT schema

[Krzysztof Kozlowski <krzk@kernel.org>]

On Thu, Apr 23, 2026 at 01:32:00AM +0530, Shaunak Datar wrote:
> Convert the Hisilicon Hi655x PMIC binding from the text format to DT schema
> to enable dtbs_check validation

Missing blank line

> Signed-off-by: Shaunak Datar <shaunakkdatar@gmail.com>
> ---
>  .../bindings/mfd/hisilicon,hi655x-pmic.yaml   | 89 +++++++++++++++++++
>  .../bindings/mfd/hisilicon,hi655x.txt         | 33 -------
>  2 files changed, 89 insertions(+), 33 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi655x-pmic.yaml
>  delete mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi655x-pmic.yaml b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x-pmic.yaml
> new file mode 100644
> index 000000000000..1bed57003bd2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x-pmic.yaml
> @@ -0,0 +1,89 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/hisilicon,hi655x-pmic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Hisilicon Hi655x Power Management Integrated Circuit
> +
> +maintainers:
> +  - Chen Feng <puck.chen@hisilicon.com>
> +  - Daniel Lezcano <daniel.lezcano@kernel.org>
> +
> +description:
> +  The hardware layout for access PMIC Hi655x from AP SoC Hi6220.
> +  Between PMIC Hi655x and Hi6220, the physical signal channel is SSI.
> +  We can use memory-mapped I/O to communicate.
> +
> +properties:
> +  $nodename:
> +    pattern: "pmic@[0-9a-f]"

Drop

> +
> +  compatible:
> +    const: hisilicon,hi655x-pmic
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupt-controller: true
> +
> +  '#interrupt-cells':
> +    const: 2
> +
> +  pmic-gpios:
> +    maxItems: 1
> +    description: The GPIO used by PMIC IRQ
> +
> +  '#clock-cells':
> +    const: 0
> +
> +  clock-output-names:
> +    maxItems: 1
> +
> +  regulators:

There was no such property/child before, so this must be explained in
the commit msg.

> +    type: object
> +    additionalProperties: false
> +
> +    patternProperties:
> +      '^LDO[0-9]+$':

Why 9999 regulators is valid? This is usually constrained, because
device has a very specific number of regulators.

Also, name should be 'ldo' if this is a new binding. If this is not new,
you must explain WHY you are doing these changes to the binding.

> +        type: object
> +        $ref: /schemas/regulator/regulator.yaml#
> +        unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupt-controller
> +  - '#interrupt-cells'
> +  - pmic-gpios
> +  - '#clock-cells'
> +  - regulators

And why is this required?

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    / {

Drop and use 1 as address/size-cells. Or 'soc' like in other bindings.


> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +

Best regards,
Krzysztof