All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zk47T" <zizuzacker@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: ross.burton@arm.com, mathieu.dubois-briand@bootlin.com,
	Nguyen Minh Tien <zizuzacker@gmail.com>
Subject: [PATCH v3 1/3] useradd.bbclass: allow inheriting with only USERADD_DEPENDS set
Date: Thu, 23 Apr 2026 17:04:03 +0700	[thread overview]
Message-ID: <20260423100405.25255-2-zizuzacker@gmail.com> (raw)
In-Reply-To: <20260423100405.25255-1-zizuzacker@gmail.com>

When a recipe inherits useradd and only sets USERADD_DEPENDS (to depend
on users/groups created by another recipe), without creating any
users/groups itself, the parse-time sanity check incorrectly throws a
fatal error about missing USERADD_PACKAGES.

Skip the USERADD_PACKAGES/USERADD_PARAM validation when USERADD_DEPENDS
is set but USERADD_PACKAGES is not, since the recipe only needs build
dependency tracking, not user/group creation.

Fixes [YOCTO #15863]

Signed-off-by: Nguyen Minh Tien <zizuzacker@gmail.com>
---
 meta/classes/useradd.bbclass | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
index 16a65ac323..9d857a4555 100644
--- a/meta/classes/useradd.bbclass
+++ b/meta/classes/useradd.bbclass
@@ -212,6 +212,11 @@ def update_useradd_after_parse(d):
     useradd_packages = d.getVar('USERADD_PACKAGES')
 
     if not useradd_packages:
+        # It's valid to inherit useradd and only set USERADD_DEPENDS to
+        # depend on users/groups created by another recipe, without
+        # creating any users/groups in this recipe.
+        if d.getVar('USERADD_DEPENDS'):
+            return
         bb.fatal("%s inherits useradd but doesn't set USERADD_PACKAGES" % d.getVar('FILE', False))
 
     for pkg in useradd_packages.split():
-- 
2.34.1



  reply	other threads:[~2026-04-23 11:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 16:39 [PATCH v2 0/3] useradd.bbclass: fix parse error when only USERADD_DEPENDS is set Zk47T
2026-04-20 16:39 ` [PATCH v2 1/3] useradd.bbclass: allow inheriting with only USERADD_DEPENDS set Zk47T
2026-04-20 16:39 ` [PATCH v2 2/3] meta-selftest: add usegroup-deponly recipe to test USERADD_DEPENDS only Zk47T
2026-04-20 16:39 ` [PATCH v2 3/3] oe-selftest: add test for useradd with only USERADD_DEPENDS Zk47T
2026-04-23  6:44   ` [OE-core] " Mathieu Dubois-Briand
2026-04-23 10:04     ` [PATCH v3 0/3] useradd.bbclass: fix parse error when only USERADD_DEPENDS is set Zk47T
2026-04-23 10:04       ` Zk47T [this message]
2026-04-23 10:04       ` [PATCH v3 2/3] meta-selftest: add usegroup-deponly recipe to test USERADD_DEPENDS only Zk47T
2026-04-23 10:04       ` [PATCH v3 3/3] oe-selftest: add test for useradd with only USERADD_DEPENDS Zk47T
2026-04-23 10:09         ` Zk47T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260423100405.25255-2-zizuzacker@gmail.com \
    --to=zizuzacker@gmail.com \
    --cc=mathieu.dubois-briand@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.