From: Jakub Kicinski <kuba@kernel.org>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: Antonio Quartulli <antonio@openvpn.net>,
netdev@vger.kernel.org, Ralf Lici <ralf@mandelbit.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Hyunwoo Kim <imv4bel@gmail.com>
Subject: Re: [PATCH net 1/1] ovpn: fix race between deleting interface and adding new peer
Date: Thu, 23 Apr 2026 10:36:28 -0700 [thread overview]
Message-ID: <20260423103628.4ce6fc05@kernel.org> (raw)
In-Reply-To: <aepK3XXc8IFemb1Z@krikkit>
On Thu, 23 Apr 2026 18:37:49 +0200 Sabrina Dubroca wrote:
> We could also wrap all of ovpn_peer_add (including the new reg_state
> check) in netdev_lock, since we can't move to NETREG_UNREGISTERING
> until netdev_lock is released (then I think we wouldn't need the
> READ_ONCE(reg_state)). But I don't know if that's an acceptable use of
> netdev_lock.
Yup, fwiw it's a perfectly legitimate use case.
next prev parent reply other threads:[~2026-04-23 17:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 12:32 [PATCH net 0/1] pull request: fixes for ovpn 2026-04-22 Antonio Quartulli
2026-04-22 12:32 ` [PATCH net 1/1] ovpn: fix race between deleting interface and adding new peer Antonio Quartulli
2026-04-23 2:20 ` Jakub Kicinski
2026-04-23 12:16 ` Antonio Quartulli
2026-04-23 13:43 ` Antonio Quartulli
2026-04-23 16:37 ` Sabrina Dubroca
2026-04-23 17:36 ` Jakub Kicinski [this message]
2026-04-23 22:27 ` Sabrina Dubroca
2026-04-27 20:22 ` Jakub Kicinski
2026-04-23 17:38 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2026-03-20 10:03 [PATCH net 0/1] pull request: fixes for ovpn 2026-03-20 Antonio Quartulli
2026-03-20 10:03 ` [PATCH net 1/1] ovpn: fix race between deleting interface and adding new peer Antonio Quartulli
2026-03-24 1:43 ` Jakub Kicinski
2026-03-24 1:45 ` Jakub Kicinski
2026-03-24 10:09 ` Sabrina Dubroca
2026-03-24 21:30 ` Jakub Kicinski
2026-03-24 22:40 ` Sabrina Dubroca
2026-03-25 13:37 ` Antonio Quartulli
2026-03-26 9:13 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260423103628.4ce6fc05@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=antonio@openvpn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imv4bel@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ralf@mandelbit.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.