From: Simon Horman <horms@kernel.org>
To: Ernestas Kulik <ernestas.k@iconn-networks.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] llc: Return -EINPROGRESS from llc_ui_connect()
Date: Thu, 23 Apr 2026 18:26:21 +0100 [thread overview]
Message-ID: <20260423172621.GH900403@horms.kernel.org> (raw)
In-Reply-To: <20260421060304.285419-1-ernestas.k@iconn-networks.com>
On Tue, Apr 21, 2026 at 09:02:26AM +0300, Ernestas Kulik wrote:
> Given a zero sk_sndtimeo, llc_ui_connect() skips waiting for state
> change and returns 0, confusing userspace applications that will assume
> the socket is connected, making e.g. getpeername() calls error out.
>
> More specifically, the issue was discovered in libcoap, where
> newly-added AF_LLC socket support was behaving differently from AF_INET
> connections due to EINPROGRESS handling being skipped.
>
> Set rc to -EINPROGRESS if connect() would not block, akin to AF_INET
> sockets.
>
> Signed-off-by: Ernestas Kulik <ernestas.k@iconn-networks.com>
> ---
> v2:
> - Add note about discovering the issue
> - Make rc assignment conditional
> v3:
> - Fix commit message after v2 changes
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-04-23 17:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 6:34 [PATCH] llc: Return -EINPROGRESS from llc_ui_connect() Ernestas Kulik
2026-04-20 18:41 ` Jakub Kicinski
2026-04-21 5:48 ` Ernestas Kulik
2026-04-21 5:54 ` [PATCH v2] " Ernestas Kulik
2026-04-21 6:02 ` [PATCH v3] " Ernestas Kulik
2026-04-23 17:26 ` Simon Horman [this message]
2026-04-23 18:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260423172621.GH900403@horms.kernel.org \
--to=horms@kernel.org \
--cc=ernestas.k@iconn-networks.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.