From: Johan Hovold <johan@kernel.org>
To: Geoff Levand <geoff@infradead.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <chleroy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>
Subject: [PATCH 3/3] powerpc/pseries: clean up ibmebus printks
Date: Fri, 24 Apr 2026 12:36:04 +0200 [thread overview]
Message-ID: <20260424103604.2616657-4-johan@kernel.org> (raw)
In-Reply-To: <20260424103604.2616657-1-johan@kernel.org>
Clean up the imbebus printks by switching to pr_warn() and pr_err(),
adding a missing newline and making the error messages a bit more
uniform.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
arch/powerpc/platforms/pseries/ibmebus.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/ibmebus.c b/arch/powerpc/platforms/pseries/ibmebus.c
index e3b41e2d844f..8797b2137d9c 100644
--- a/arch/powerpc/platforms/pseries/ibmebus.c
+++ b/arch/powerpc/platforms/pseries/ibmebus.c
@@ -203,8 +203,7 @@ static int ibmebus_create_devices(const struct of_device_id *matches)
ret = ibmebus_create_device(child);
if (ret) {
- printk(KERN_ERR "%s: failed to create device (%i)",
- __func__, ret);
+ pr_err("%s: failed to create device: %d\n", __func__, ret);
of_node_put(child);
break;
}
@@ -282,8 +281,7 @@ static ssize_t probe_store(const struct bus_type *bus, const char *buf, size_t c
ibmebus_match_path);
if (dev) {
put_device(dev);
- printk(KERN_WARNING "%s: %s has already been probed\n",
- __func__, path);
+ pr_warn("%s: %s has already been probed\n", __func__, path);
rc = -EEXIST;
goto out;
}
@@ -292,8 +290,7 @@ static ssize_t probe_store(const struct bus_type *bus, const char *buf, size_t c
rc = ibmebus_create_device(dn);
of_node_put(dn);
} else {
- printk(KERN_WARNING "%s: no such device node: %s\n",
- __func__, path);
+ pr_warn("%s: no such device node: %s\n", __func__, path);
rc = -ENODEV;
}
@@ -322,8 +319,7 @@ static ssize_t remove_store(const struct bus_type *bus, const char *buf, size_t
kfree(path);
return count;
} else {
- printk(KERN_WARNING "%s: %s not on the bus\n",
- __func__, path);
+ pr_warn("%s: %s not on the bus\n", __func__, path);
kfree(path);
return -ENODEV;
@@ -447,20 +443,18 @@ static int __init ibmebus_bus_init(void)
{
int err;
- printk(KERN_INFO "IBM eBus Device Driver\n");
+ pr_info("IBM eBus Device Driver\n");
err = bus_register(&ibmebus_bus_type);
if (err) {
- printk(KERN_ERR "%s: failed to register IBM eBus.\n",
- __func__);
+ pr_err("%s: failed to register IBM eBus\n", __func__);
return err;
}
ibmebus_bus_device = root_device_register("ibmebus");
if (IS_ERR(ibmebus_bus_device)) {
err = PTR_ERR(ibmebus_bus_device);
- printk(KERN_WARNING "%s: root_device_register returned %i\n",
- __func__, err);
+ pr_err("%s: failed to register root device: %d\n", __func__, err);
bus_unregister(&ibmebus_bus_type);
return err;
--
2.53.0
prev parent reply other threads:[~2026-04-24 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 10:36 [PATCH 0/3] powerpc: switch to dynamic root devices Johan Hovold
2026-04-24 10:36 ` [PATCH 1/3] powerpc/ps3: switch to dynamic system bus root device Johan Hovold
2026-04-24 10:36 ` [PATCH 2/3] powerpc/pseries: switch to dynamic ibmebus " Johan Hovold
2026-04-24 10:36 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260424103604.2616657-4-johan@kernel.org \
--to=johan@kernel.org \
--cc=chleroy@kernel.org \
--cc=geoff@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.