From: "Michael S. Tsirkin" <mst@redhat.com>
To: Albert Esteve <aesteve@redhat.com>
Cc: "Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org,
gnurou@gmail.com
Subject: Re: [PATCH] virtio: Add ID for virtio media
Date: Fri, 24 Apr 2026 12:31:50 -0400 [thread overview]
Message-ID: <20260424123123-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CADSE00JEjrecyM==PyjX9LT5X62awYQOn3as-KFGYQrSD0+K_w@mail.gmail.com>
On Fri, Apr 24, 2026 at 03:37:14PM +0200, Albert Esteve wrote:
> On Fri, Apr 24, 2026 at 3:07 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Thu, Apr 09, 2026 at 06:53:41PM +0200, Albert Esteve wrote:
> > > Hi,
> > >
> > >
> > > On Tue, Mar 10, 2026 at 9:41 AM Albert Esteve <aesteve@redhat.com> wrote:
> > > >
> > > > Add VIRTIO_ID_MEDIA definition for virtio-media.
> > > >
> > > > Signed-off-by: Albert Esteve <aesteve@redhat.com>
> > >
> > > Are there any thoughts on this patch, or any actions I need to take?
> > >
> > > Thanks,
> > > Albert
> >
> > Create a github issue and request a vote as documented in README.md
>
> The inclusion of this ID was already voted and approved. The device
> already appears in the VirtIO v1.4 specification, with the same ID (as
> linked below). This patch is only meant to translate the decision to
> the kernel header.
>
> >
> > > > ---
> > > > While the Linux driver for virtio media is currently under active
> > > > development and review [1], the VirtIO v1.4 specification has
> > > > already been published and oficially defines the media device type [2].
> > > >
> > > > Adding the device ID now allows other components and tools to reference it
> > > > before the driver lands, and ensures the kernel headers stay aligned
> > > > with the specification.
> > > >
> > > > [1] https://lore.kernel.org/linux-media/20250412-virtio-media-v3-1-97dc94c18398@gmail.com/
> > > > [2] https://docs.oasis-open.org/virtio/virtio/v1.4/virtio-v1.4.html#x1-82200022
> > > > ---
> > > > include/uapi/linux/virtio_ids.h | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h
> > > > index 6c12db16faa3a..f9056af0c6223 100644
> > > > --- a/include/uapi/linux/virtio_ids.h
> > > > +++ b/include/uapi/linux/virtio_ids.h
> > > > @@ -69,6 +69,7 @@
> > > > #define VIRTIO_ID_BT 40 /* virtio bluetooth */
> > > > #define VIRTIO_ID_GPIO 41 /* virtio gpio */
> > > > #define VIRTIO_ID_SPI 45 /* virtio spi */
> > > > +#define VIRTIO_ID_MEDIA 48 /* virtio media */
> > > >
> > > > /*
> > > > * Virtio Transitional IDs
> > > >
> > > > ---
> > > > base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
> > > > change-id: 20260310-virtio-media-id-b31179fcdc44
> > > >
> > > > Best regards,
> > > > --
> > > > Albert Esteve <aesteve@redhat.com>
> > > >
> >
Oh my bad. I misfiled it into the spec folder. I will take care of this.
Thanks!
prev parent reply other threads:[~2026-04-24 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 8:40 [PATCH] virtio: Add ID for virtio media Albert Esteve
2026-04-09 16:53 ` Albert Esteve
2026-04-24 13:06 ` Michael S. Tsirkin
2026-04-24 13:37 ` Albert Esteve
2026-04-24 16:31 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260424123123-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=aesteve@redhat.com \
--cc=eperezma@redhat.com \
--cc=gnurou@gmail.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.