From: Bjorn Helgaas <helgaas@kernel.org>
To: Mahesh Vaidya <mahesh.vaidya@altera.com>
Cc: joyce.ooi@intel.com, lpieralisi@kernel.org,
kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org,
bhelgaas@google.com, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, subhransu.sekhar.prusty@altera.com,
dinguyen@kernel.org
Subject: Re: [PATCH 3/3] PCI: altera: add Agilex 5 support
Date: Fri, 24 Apr 2026 10:48:44 -0500 [thread overview]
Message-ID: <20260424154844.GA8514@bhelgaas> (raw)
In-Reply-To: <20260424094913.522123-4-mahesh.vaidya@altera.com>
Adjust subject lines of both patches to match previous style
(capitalize first word, e.g.,
PCI: altera: Add ...
On Fri, Apr 24, 2026 at 02:49:13AM -0700, Mahesh Vaidya wrote:
> Add PCIe root port controller support for the Agilex 5 (V4) family
> of SoC FPGAs.
> +++ b/drivers/pci/controller/pcie-altera.c
> @@ -12,6 +12,8 @@
> #include <linux/irqchip/chained_irq.h>
> #include <linux/irqdomain.h>
> #include <linux/init.h>
> +#include <linux/bitfield.h>
> +#include <linux/iopoll.h>
Alphabetize these to match existing style.
> +static void aglx5_isr(struct irq_desc *desc)
> +{
> + struct irq_chip *chip = irq_desc_get_chip(desc);
> + struct altera_pcie *pcie;
> + struct device *dev;
> + u32 status = 0;
> + int ret;
> +
> + chained_irq_enter(chip, desc);
> + pcie = irq_desc_get_handler_data(desc);
> + dev = &pcie->pdev->dev;
> +
> + ret = aglx5_indirect_readl(pcie, pcie->pcie_data->port_irq_status_offset, &status);
Existing code fits in 80 columns, would be nice if this and a few more
below did too.
next prev parent reply other threads:[~2026-04-24 15:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 9:49 [PATCH 0/3] PCI: altera: Add Agilex 5 PCIe Root Port support Mahesh Vaidya
2026-04-24 9:49 ` [PATCH 1/3] dt-bindings: PCI: altera: add binding for Agilex 5 Mahesh Vaidya
2026-04-25 10:22 ` Krzysztof Kozlowski
2026-04-27 12:43 ` Mahesh Vaidya
2026-04-24 9:49 ` [PATCH 2/3] PCI: altera: fix resource leaks on probe failure Mahesh Vaidya
2026-04-24 12:42 ` Dinh Nguyen
2026-04-27 12:36 ` Mahesh Vaidya
2026-04-24 9:49 ` [PATCH 3/3] PCI: altera: add Agilex 5 support Mahesh Vaidya
2026-04-24 15:48 ` Bjorn Helgaas [this message]
2026-04-27 12:49 ` Mahesh Vaidya
2026-05-12 13:05 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260424154844.GA8514@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=joyce.ooi@intel.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mahesh.vaidya@altera.com \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=subhransu.sekhar.prusty@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.