Re: [PATCH v2 0/6] iio: accel: mma8452: improve coding style, pm and resource cleanup

[Jonathan Cameron <jic23@kernel.org>]

On Wed, 22 Apr 2026 22:26:37 +0530
Sanjay Chitroda <sanjayembeddedse@gmail.com> wrote:

> From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
> 
> Hi all,
> 
> This series contains a small cleanup and improvements to use modern kernel
> helper API and coding style for mma8452 accelarator driver.
> 
> The changes modernize mutex with guard(), dev_err_probe usage,
> resolve checkpatch CHECKS and pm_ptr macro usage.

Take a look at what the sashiko checker came up with.
Some other issues in the driver beyond the ones humans reviewers
have pointed out.
https://sashiko.dev/#/patchset/20260422165643.2148195-1-sanjayembedded%40gmail.com

Be careful though - there are false positives in the output
of this tool so check everything carefully. 

Jonathan

> 
> Changes in v2:
> - 0005: address review comment from Andy and Geert
>   and use DEFINE_RUNTIME_DEV_PM_OPS macro
> - Added new cleanup channges in mma8452 driver
> 
> No functional behavior changes are intended.
> 
> Testing:
>   - Compiled with W=1
>   - Build-tested on QEMU x86_64
> 
> Feedback and reviews are very welcome.
> 
> Thanks,
> Sanjay Chitroda
> 
> Sanjay Chitroda (6):
>   iio: accel: mma8452: cleanup codestyle warning
>   iio: accel: mma8452: sort headers alphabetically
>   iio: accel: mma8452: use local struct device
>   iio: accel: mma8452: Use dev_err_probe()
>   iio: accel: mma8452: use pm_ptr() for dev_pm_ops
>   iio: accel: mma8452: use guard() to release mutexes
> 
>  drivers/iio/accel/mma8452.c | 161 +++++++++++++++++-------------------
>  1 file changed, 76 insertions(+), 85 deletions(-)
> 
> 
> base-commit: eade2b843d9b1f668fc1775f15611bb0a1999cd9