From: Peter Fang <peter.fang@intel.com>
To: Gautam Menghani <gautam@linux.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
Yosry Ahmed <yosry@kernel.org>,
Ritesh Harjani <ritesh.list@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>, <kvm@vger.kernel.org>,
<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] KVM: Take gpa_t in kvm_vcpu_map[_readonly]()
Date: Fri, 24 Apr 2026 21:25:34 -0700 [thread overview]
Message-ID: <20260425042534.GC1733452@pedri> (raw)
In-Reply-To: <aeso7lRjzDhIKEXV@Gautams-MacBook-Pro.local>
On Fri, Apr 24, 2026 at 01:55:18PM +0530, Gautam Menghani wrote:
> On Tue, Apr 07, 2026 at 05:11:30PM -0700, Peter Fang wrote:
> > Move the conversion from a gpa_t to a gfn_t into kvm_vcpu_map() and
> > kvm_vcpu_map_readonly() so that they take a gpa_t directly, reducing
> > boilerplate at call sites.
>
> For this refactor, shouldn't the prototypes continue to take in gpa? I
> think this was agreed in v1? [1]
>
> Am I missing something?
Patch 1 first does the "quick fix" of changing the prototypes to take
gfn_t, and then patch 3 changes the prototypes back to taking gpa_t so
that callers don't need to use gpa_to_gfn(). Hope that clarifies the
series.
>
> [1] : https://lore.kernel.org/kvm/ac8BOGXIPMnJ7kIg@google.com/
>
> Thanks,
> Gautam
next prev parent reply other threads:[~2026-04-25 4:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 0:11 [PATCH v2 0/3] KVM: Fix and clean up kvm_vcpu_map[_readonly]() usages Peter Fang
2026-04-08 0:11 ` [PATCH v2 1/3] KVM: Fix kvm_vcpu_map[_readonly]() function prototypes Peter Fang
2026-04-21 23:05 ` Yosry Ahmed
2026-04-08 0:11 ` [PATCH v2 2/3] KVM: Move page mapping/unmapping APIs in kvm_host.h Peter Fang
2026-04-21 23:06 ` Yosry Ahmed
2026-04-08 0:11 ` [PATCH v2 3/3] KVM: Take gpa_t in kvm_vcpu_map[_readonly]() Peter Fang
2026-04-21 23:08 ` Yosry Ahmed
2026-04-21 23:19 ` Sean Christopherson
2026-04-21 23:25 ` Yosry Ahmed
2026-04-21 23:29 ` Sean Christopherson
2026-04-21 23:41 ` Yosry Ahmed
2026-04-22 0:27 ` Sean Christopherson
2026-04-22 20:19 ` Yosry Ahmed
2026-04-22 20:34 ` Sean Christopherson
2026-04-22 21:44 ` Yosry Ahmed
2026-04-22 22:17 ` Sean Christopherson
2026-04-22 22:19 ` Yosry Ahmed
2026-04-23 7:49 ` Peter Fang
2026-04-24 8:25 ` Gautam Menghani
2026-04-25 4:25 ` Peter Fang [this message]
2026-04-24 10:27 ` [PATCH v2 0/3] KVM: Fix and clean up kvm_vcpu_map[_readonly]() usages David Woodhouse
2026-04-27 8:05 ` Peter Fang
2026-05-04 17:59 ` Sean Christopherson
2026-05-07 8:18 ` Peter Fang
2026-05-13 17:33 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260425042534.GC1733452@pedri \
--to=peter.fang@intel.com \
--cc=bp@alien8.de \
--cc=chleroy@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=gautam@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=ritesh.list@gmail.com \
--cc=seanjc@google.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=yosry@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.