All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Ravi Jonnalagadda <ravis.opensrc@gmail.com>
Cc: SeongJae Park <sj@kernel.org>,
	damon@lists.linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	akpm@linux-foundation.org, corbet@lwn.net, bijan311@gmail.com,
	ajayjoshi@micron.com, honggyu.kim@sk.com, yunjeong.mun@sk.com
Subject: Re: [PATCH v7] mm/damon: add node_eligible_mem_bp goal metric
Date: Sat, 25 Apr 2026 08:37:21 -0700	[thread overview]
Message-ID: <20260425153723.89488-1-sj@kernel.org> (raw)
In-Reply-To: <CALa+Y16VuXb2DfeiBiE5avpEsqGVfc6DAKZWacNsu-1hD51hMQ@mail.gmail.com>

On Fri, 24 Apr 2026 21:18:57 -0700 Ravi Jonnalagadda <ravis.opensrc@gmail.com> wrote:

> On Fri, Apr 24, 2026 at 5:39 PM SeongJae Park <sj@kernel.org> wrote:
> >
> > Hello Ravi,
> >
> >
> > This version looks good, except very trivial nits.
> 
>  Hi SJ,
> 
>   Thanks for the super quick review! Very helpful.

My pleasure!

[...]
> > So this looks good to me, except the trivial things I commented above.  Could
> > you please revision for the last time?
> 
> Will do. Summary of changes for v8:
>   1. Mention addr filters for source-node filtering in Two-Scheme
> Setup
>   2. Move implementation details to commentary area with full
> changelog
>   3. Wrap the 80-column violation in damon_commit_ctx()
>   4. Use PAGE_ALIGN_DOWN(addr + PAGE_SIZE) for alignment
>   5. Wrap damos_goal_tune_esz_bp_temporal() (81 chars)
>   6. Remove unintended damos_trace_esz() from first charge window

Sounds good, looking forward to the v8!


Thanks,
SJ

[...]

      reply	other threads:[~2026-04-25 15:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-24 20:34 [PATCH v7] mm/damon: add node_eligible_mem_bp goal metric Ravi Jonnalagadda
2026-04-24 20:59 ` sashiko-bot
2026-04-25  0:45   ` SeongJae Park
2026-04-25  0:39 ` SeongJae Park
2026-04-25  4:18   ` Ravi Jonnalagadda
2026-04-25 15:37     ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260425153723.89488-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=ajayjoshi@micron.com \
    --cc=akpm@linux-foundation.org \
    --cc=bijan311@gmail.com \
    --cc=corbet@lwn.net \
    --cc=damon@lists.linux.dev \
    --cc=honggyu.kim@sk.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ravis.opensrc@gmail.com \
    --cc=yunjeong.mun@sk.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.