From: Helge Deller <deller@kernel.org>
To: qemu-devel@nongnu.org
Cc: "Helge Deller" <deller@gmx.de>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 13/14] linux-user: Use abi_int for imr_ifindex in ip_mreqn struct
Date: Sat, 25 Apr 2026 17:51:39 +0200 [thread overview]
Message-ID: <20260425155140.50186-14-deller@kernel.org> (raw)
In-Reply-To: <20260425155140.50186-1-deller@kernel.org>
From: Helge Deller <deller@gmx.de>
Peter Hartley noticed, that in the qemu code the imr_ifindex member of
struct target_ip_mreq needs to be of type "int" instead of "long", which
is what the Linux kernel uses on all architectures.
Adjust the type accordingly, and add a QEMU_BUILD_BUG_ON() checker to
prevent such issues in the future.
This change should fix multicast issues when using hosts and guests with
different endianess or bit size.
Reported-by: Peter Hartley <peter@talesfromthearmchair.net>
Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/2553
Signed-off-by: Helge Deller <deller@gmx.de>
---
linux-user/syscall.c | 2 ++
linux-user/syscall_defs.h | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 910a4da0a6..4594909242 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -2161,6 +2161,8 @@ static abi_long do_setsockopt(int sockfd, int level, int optname,
QEMU_BUILD_BUG_ON(sizeof(struct ip_mreq) !=
sizeof(struct target_ip_mreq));
+ QEMU_BUILD_BUG_ON(sizeof(struct ip_mreqn) !=
+ sizeof(struct target_ip_mreqn));
if (optname == IP_MULTICAST_IF) {
min_size = sizeof(struct in_addr);
diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
index 6967306be4..5799769f83 100644
--- a/linux-user/syscall_defs.h
+++ b/linux-user/syscall_defs.h
@@ -210,7 +210,7 @@ struct target_ip_mreq {
struct target_ip_mreqn {
struct target_in_addr imr_multiaddr;
struct target_in_addr imr_address;
- abi_long imr_ifindex;
+ abi_int imr_ifindex;
};
struct target_ip_mreq_source {
--
2.53.0
next prev parent reply other threads:[~2026-04-25 15:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-25 15:51 [PULL 00/14] Linux user next patches Helge Deller
2026-04-25 15:51 ` [PULL 01/14] MAINTAINERS: Add myself as maintainer for linux-user Helge Deller
2026-04-25 15:51 ` [PULL 02/14] linux-user/ppc: Fix ppc64 rt_sigframe stack offset Helge Deller
2026-04-25 15:51 ` [PULL 03/14] linux-user: fix off-by-one in host_to_target_for_each_rtattr() Helge Deller
2026-04-25 15:51 ` [PULL 04/14] linux-user: Don't define target_stat64 struct for loongarch64 Helge Deller
2026-04-25 15:51 ` [PULL 05/14] linux-user/arm/nwfpe: Replace user_registers with current_cpu Helge Deller
2026-04-25 15:51 ` [PULL 06/14] linux-user/arm/nwfpe: Use thread-local storage for qemufpa Helge Deller
2026-04-25 15:51 ` [PULL 07/14] linux-user/strace: Use pointer type for read and write values Helge Deller
2026-04-25 15:51 ` [PULL 08/14] linux-user/mips: sync k0 TLS for EF_MIPS_MACH_OCTEON userlands Helge Deller
2026-04-25 15:51 ` [PULL 09/14] linux-user: Define SO_TIMESTAMP*_NEW and SO_RCVTIMEIO_NEW Helge Deller
2026-04-25 15:51 ` [PULL 10/14] linux-user: Add setsockopt() for SO_RCVTIMEO_NEW and SO_SNDTIMEO_NEW Helge Deller
2026-04-25 15:51 ` [PULL 11/14] linux-user: Add getsockopt() " Helge Deller
2026-04-25 15:51 ` [PULL 12/14] linux-user: Fix CLONE_PARENT_SETTID when using fork-like clone Helge Deller
2026-04-25 15:51 ` Helge Deller [this message]
2026-04-25 15:51 ` [PULL 14/14] linux-user: Flush errors by using exit() instead of _exit() in error path Helge Deller
2026-04-27 6:28 ` Philippe Mathieu-Daudé
2026-04-28 12:02 ` [PULL 00/14] Linux user next patches Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260425155140.50186-14-deller@kernel.org \
--to=deller@kernel.org \
--cc=deller@gmx.de \
--cc=jiaxun.yang@flygoat.com \
--cc=laurent@vivier.eu \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.