From: Greg KH <gregkh@linuxfoundation.org>
To: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] staging: sm750fb: Rename sm750_dev members to snake_case
Date: Sun, 26 Apr 2026 21:10:41 +0200 [thread overview]
Message-ID: <2026042602-audible-amber-3451@gregkh> (raw)
In-Reply-To: <20260407074805.14505-4-chakrabortyshubham66@gmail.com>
On Tue, Apr 07, 2026 at 01:18:05PM +0530, Shubham Chakraborty wrote:
> diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
> index b683a82af349..3f6570fc8f08 100644
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -97,8 +97,8 @@ struct sm750_dev {
> unsigned long vidreg_start;
> __u32 vidmem_size;
> __u32 vidreg_size;
> - void __iomem *pvReg;
> - unsigned char __iomem *pvMem;
> + void __iomem *pv_reg;
> + unsigned char __iomem *pv_mem;
Why are you keeping the "pv" prefix? As you know, that's an old-style
notation to try to say this is a pointer to a void, which obviously is
not the kernel coding style.
thanks,
greg k-h
prev parent reply other threads:[~2026-04-27 3:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 7:48 [PATCH v3 0/3] staging: sm750fb: Rename CamelCase identifiers Shubham Chakraborty
2026-04-07 7:48 ` [PATCH v3 1/3] staging: sm750fb: Rename sm750_pnltype enum values to upper case Shubham Chakraborty
2026-04-07 7:48 ` [PATCH v3 2/3] staging: sm750fb: Rename init_status members to snake_case Shubham Chakraborty
2026-04-26 19:09 ` Greg KH
2026-04-07 7:48 ` [PATCH v3 3/3] staging: sm750fb: Rename sm750_dev " Shubham Chakraborty
2026-04-26 19:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026042602-audible-amber-3451@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=chakrabortyshubham66@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.