All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eric Wu <kunjinkao.jp@gmail.com>
Cc: Yoelvis Oliveros <yoelvisoliveros@gmail.com>,
	Len Bao <len.bao@gmx.us>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: octeon: remove typedefs from octeon-stubs.h
Date: Sun, 26 Apr 2026 20:56:33 +0200	[thread overview]
Message-ID: <2026042610-winner-affecting-a263@gregkh> (raw)
In-Reply-To: <20260426031100.97996-1-kunjinkao.jp@gmail.com>

On Sun, Apr 26, 2026 at 11:11:00AM +0800, Eric Wu wrote:
> The Linux kernel coding style discourages the use of typedefs for
> enums and structs. checkpatch reports seven "do not add new typedefs"
> warnings on drivers/staging/octeon/octeon-stubs.h.
> 
> Drop the typedef wrappers in octeon-stubs.h and convert the affected
> users in ethernet.c and octeon-ethernet.h to use the underlying
> 'enum cvmx_*' / 'struct cvmx_*' tags directly.
> 
> No functional change. Compile-tested with CONFIG_COMPILE_TEST=y and
> CONFIG_OCTEON_ETHERNET=m on x86_64; both default and W=1 builds are
> clean.

As was stated to others attempting to do this, this should be a patch
series, with one patch per enum changed, right?

thanks,

greg k-h

      reply	other threads:[~2026-04-27  3:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-26  3:11 [PATCH] staging: octeon: remove typedefs from octeon-stubs.h Eric Wu
2026-04-26 18:56 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026042610-winner-affecting-a263@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=kunjinkao.jp@gmail.com \
    --cc=len.bao@gmx.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=yoelvisoliveros@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.