From: David Laight <david.laight.linux@gmail.com>
To: "Mukesh Kumar Chaurasiya (IBM)" <mkchauras@gmail.com>
Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
chleroy@kernel.org, peterz@infradead.org, jpoimboe@kernel.org,
jbaron@akamai.com, aliceryhl@google.com, rostedt@goodmis.org,
ardb@kernel.org, ojeda@kernel.org, boqun@kernel.org,
gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, tmgross@umich.edu, dakr@kernel.org,
nathan@kernel.org, nick.desaulniers+lkml@gmail.com,
morbo@google.com, justinstitt@google.com,
daniel.almeida@collabora.com, fujita.tomonori@gmail.com,
viresh.kumar@linaro.org, prafulrai522@gmail.com,
gregkh@linuxfoundation.org, arnd@arndb.de, tamird@kernel.org,
lyude@redhat.com, airlied@gmail.com, j@jannau.net,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org, llvm@lists.linux.dev,
Link Mauve <linkmauve@linkmauve.fr>
Subject: Re: [PATCH V14 5/7] rust: Make __udivdi3() and __umoddi3() panic
Date: Sun, 26 Apr 2026 12:49:21 +0100 [thread overview]
Message-ID: <20260426124921.28eb433f@pumpkin> (raw)
In-Reply-To: <20260426085725.2090827-6-mkchauras@gmail.com>
On Sun, 26 Apr 2026 14:27:23 +0530
"Mukesh Kumar Chaurasiya (IBM)" <mkchauras@gmail.com> wrote:
> From: Link Mauve <linkmauve@linkmauve.fr>
>
> The core crate currently depends on these two functions for i64/u64/
> i128/u128/core::time::Duration formatting, but we shouldn’t use that in
> the kernel so let’s panic if they are ever called.
>
> This doesn’t yet fix drm_panic_qr.rs, which also uses __udivdi3 when
> CONFIG_CC_OPTIMIZE_FOR_SIZE=y, but at least makes the rest of the kernel
> build on PPC32.
This needs resolving properly.
>
> Signed-off-by: Link Mauve <linkmauve@linkmauve.fr>
> Signed-off-by: Mukesh Kumar Chaurasiya (IBM) <mkchauras@gmail.com>
> ---
> rust/Makefile | 4 ++++
> rust/compiler_builtins.rs | 6 ++++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/rust/Makefile b/rust/Makefile
> index f6369d121c50..9aa18cff2fae 100644
> --- a/rust/Makefile
> +++ b/rust/Makefile
> @@ -615,6 +615,10 @@ ifneq ($(or $(CONFIG_ARM64),$(and $(CONFIG_RISCV),$(CONFIG_64BIT))),)
> __ashrti3 \
> __ashlti3 __lshrti3
> endif
> +ifdef CONFIG_PPC32
> + redirect-intrinsics += \
> + __udivdi3 __umoddi3
> +endif
>
> ifdef CONFIG_MODVERSIONS
> cmd_gendwarfksyms = $(if $(skip_gendwarfksyms),, \
> diff --git a/rust/compiler_builtins.rs b/rust/compiler_builtins.rs
> index dd16c1dc899c..fc6b54636dd5 100644
> --- a/rust/compiler_builtins.rs
> +++ b/rust/compiler_builtins.rs
> @@ -97,5 +97,11 @@ pub extern "C" fn $ident() {
> __aeabi_uldivmod,
> });
>
> +#[cfg(target_arch = "powerpc")]
> +define_panicking_intrinsics!("`u64` division/modulo should not be used", {
> + __udivdi3,
> + __umoddi3,
> +});
> +
> // NOTE: if you are adding a new intrinsic here, you should also add it to
> // `redirect-intrinsics` in `rust/Makefile`.
next prev parent reply other threads:[~2026-04-26 11:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 8:57 [PATCH V14 0/7] Rust support for powerpc Mukesh Kumar Chaurasiya (IBM)
2026-04-26 8:57 ` [PATCH V14 1/7] rust: Fix "multiple candidates for rmeta dependency core" error Mukesh Kumar Chaurasiya (IBM)
2026-04-26 8:57 ` [PATCH V14 2/7] dma-resv: Fix undefined symbol when CONFIG_DMA_SHARED_BUFFER is disabled Mukesh Kumar Chaurasiya (IBM)
2026-04-26 8:57 ` [PATCH V14 3/7] powerpc/jump_label: adjust inline asm to be consistent Mukesh Kumar Chaurasiya (IBM)
2026-04-26 8:57 ` [PATCH V14 4/7] rust/powerpc: Set min rustc version for powerpc Mukesh Kumar Chaurasiya (IBM)
2026-04-26 8:57 ` [PATCH V14 5/7] rust: Make __udivdi3() and __umoddi3() panic Mukesh Kumar Chaurasiya (IBM)
2026-04-26 11:49 ` David Laight [this message]
2026-04-26 11:54 ` Mukesh Kumar Chaurasiya
2026-04-26 8:57 ` [PATCH V14 6/7] rust: Add PowerPC support Mukesh Kumar Chaurasiya (IBM)
2026-04-26 8:57 ` [PATCH V14 7/7] powerpc: Enable Rust for ppc64le Mukesh Kumar Chaurasiya (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260426124921.28eb433f@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=chleroy@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=j@jannau.net \
--cc=jbaron@akamai.com \
--cc=jpoimboe@kernel.org \
--cc=justinstitt@google.com \
--cc=linkmauve@linkmauve.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=maddy@linux.ibm.com \
--cc=mkchauras@gmail.com \
--cc=morbo@google.com \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=npiggin@gmail.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=prafulrai522@gmail.com \
--cc=rostedt@goodmis.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.